Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add confirmation badge to flow #2183

Merged
merged 3 commits into from
Jun 27, 2023
Merged

Conversation

iamacook
Copy link
Member

What it solves

Resolves missing badge

How this PR fixes it

A "+1" confirmation badge has been added to the "Confirmed (x of y)" step of the TxStatusWidget according to the designs.

How to test it

  • Create a transaction and observe the badge.
  • Confirm a transaction and observe the badge.
  • Execute a transaction that you have already confirmed and observe no badge.

Screenshots

image

image

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook self-assigned this Jun 27, 2023
@github-actions
Copy link

github-actions bot commented Jun 27, 2023

Branch preview

✅ Deploy successful!

https://confirmation_badge--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@iamacook iamacook merged commit b0d9964 into epic-tx-flow Jun 27, 2023
@iamacook iamacook deleted the confirmation-badge branch June 27, 2023 10:07
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants