Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make balance change more compact #2186

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Conversation

iamacook
Copy link
Member

What it solves

Resolves size of balance change element

How this PR fixes it

The balance change element has been made more compact according to the designs (singular, multutiple).

How to test it

Create a transaction sending one/multipl assets and observe the new design.

Screenshots

image

image

image

image

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook self-assigned this Jun 27, 2023
@github-actions
Copy link

github-actions bot commented Jun 27, 2023

Branch preview

✅ Deploy successful!

https://compact_balance_change--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Jun 27, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@katspaugh
Copy link
Member

I think the gap between multisend rows is bigger in the design.

@iamacook
Copy link
Member Author

I think the gap between multisend rows is bigger in the design.

I've updated it accordingly:

image

@iamacook iamacook merged commit 0b21e3f into epic-tx-flow Jun 27, 2023
6 of 7 checks passed
@iamacook iamacook deleted the compact-balance-change branch June 27, 2023 12:50
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants