Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: limit origin length #2334

Merged
merged 3 commits into from
Aug 7, 2023
Merged

fix: limit origin length #2334

merged 3 commits into from
Aug 7, 2023

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Jul 31, 2023

What it solves

Resolves #2180

How this PR fixes it

The origin is now limited to a total of 200 characters as follows. The url can be as long as necessary as long as it's less than 200 characters and the name is takes up the remaining characters

How to test it

See issue description.

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook requested a review from schmanu July 31, 2023 14:54
@iamacook iamacook self-assigned this Jul 31, 2023
@github-actions
Copy link

github-actions bot commented Jul 31, 2023

Branch preview

✅ Deploy successful!

https://origin_length--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Jul 31, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@katspaugh
Copy link
Member

It should be the other way round. Prio to the URL, name up to the rest of chars.

@iamacook iamacook requested a review from katspaugh July 31, 2023 17:42
@katspaugh katspaugh merged commit 7556391 into dev Aug 7, 2023
5 of 7 checks passed
@katspaugh katspaugh deleted the origin-length branch August 7, 2023 13:36
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error 1337: {"origin": [Ensure this field has no more than 200 characters]}
3 participants