Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Open custom safe apps on click #2350

Merged
merged 1 commit into from
Aug 7, 2023
Merged

fix: Open custom safe apps on click #2350

merged 1 commit into from
Aug 7, 2023

Conversation

usame-algan
Copy link
Member

What it solves

Resolves #2349

How this PR fixes it

  • Moves the check if a safe app was previously open further up the call tree into handleSafeAppClick

How to test it

  1. Open the custom safe apps tab
  2. Add a custom safe app
  3. Click on it
  4. Observe that it directly opens
  5. Navigate to the safe apps list
  6. Click on a safe app
  7. Observe that the drawer opens
  8. Open that safe app
  9. Navigate back to the safe apps list
  10. Click on the same safe app again
  11. Observe that it opens directly without a drawer

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@github-actions
Copy link

github-actions bot commented Aug 4, 2023

Branch preview

✅ Deploy successful!

https://fix_custom_safe_apps--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Aug 4, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@francovenica
Copy link
Contributor

francovenica commented Aug 6, 2023

LGTM.
Custom apps now open fine, with no drawer. You can still open the drawer if you click the " i " icon
Regular apps still open the drawer the 1st time they are opened and not more after that

Note: The test failing seems to be the Gorli/Goerli thing. We should standarize that instead of using regex in the tests

@katspaugh katspaugh merged commit bd9118c into dev Aug 7, 2023
6 of 7 checks passed
@katspaugh katspaugh deleted the fix-custom-safe-apps branch August 7, 2023 10:12
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not possible to open custom safe apps
3 participants