Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: separate stored WalletConnect sessions #2793

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Fix: separate stored WalletConnect sessions #2793

merged 1 commit into from
Nov 20, 2023

Conversation

katspaugh
Copy link
Member

@katspaugh katspaugh commented Nov 13, 2023

What it solves

Resolves #2790. Stored sessions are now separarated with a prefix. Thanks @iamacook for the alpha!

Copy link

github-actions bot commented Nov 13, 2023

Branch preview

✅ Deploy successful!

https://fix_wc--walletweb.review-wallet-web.5afe.dev

Copy link

github-actions bot commented Nov 13, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Nov 13, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 75.12% 10095/13439
🔴 Branches 49.67% 2051/4129
🔴 Functions 57.62% 1504/2610
🟡 Lines 76.7% 9126/11899

Test suite run success

1105 tests passing in 155 suites.

Report generated by 🧪jest coverage report action from 9fb976c

@katspaugh katspaugh marked this pull request as draft November 13, 2023 11:44
@katspaugh katspaugh changed the title Fix: filter WC sessions by self metadata Fix: separate stored WalletConnect sessions Nov 20, 2023
Copy link

github-actions bot commented Nov 20, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@katspaugh katspaugh requested review from liliya-soroka and removed request for usame-algan November 20, 2023 08:30
Copy link

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 1.4 MB (-20 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@katspaugh katspaugh marked this pull request as ready for review November 20, 2023 08:54
@katspaugh katspaugh merged commit 4a78e00 into dev Nov 20, 2023
14 checks passed
@katspaugh katspaugh deleted the fix-wc branch November 20, 2023 13:43
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2023
@katspaugh katspaugh added this to the 1.23.0 milestone Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WC - The safe connects with itself after refreshing
1 participant