Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: remove deprecated mobile pairing #2794

Merged
merged 5 commits into from
Nov 20, 2023
Merged

Fix: remove deprecated mobile pairing #2794

merged 5 commits into from
Nov 20, 2023

Conversation

katspaugh
Copy link
Member

What it solves

Mobile pairing will be deprecated on Nov 15, so we can remove it from the code.

Copy link

github-actions bot commented Nov 13, 2023

Branch preview

✅ Deploy successful!

https://rm_pairing--walletweb.review-wallet-web.5afe.dev

Copy link

github-actions bot commented Nov 13, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Nov 13, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.92% (+0.79% 🔼)
9981/13147
🔴 Branches
50.16% (+0.46% 🔼)
2033/4053
🔴 Functions
58.73% (+1.1% 🔼)
1494/2544
🟡 Lines
77.49% (+0.79% 🔼)
9018/11637
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / Storage.ts
59.57% (-6.38% 🔻)
60%
40% (-10% 🔻)
57.78% (-6.67% 🔻)
🔴
... / useOnboard.ts
48.57% (-1.87% 🔻)
27.27% (+0.8% 🔼)
20%
50.56% (-2.02% 🔻)
🔴
... / wallets.ts
34.62% (-0.57% 🔻)
0% 0%
43.9% (-0.28% 🔻)

Test suite run success

1095 tests passing in 154 suites.

Report generated by 🧪jest coverage report action from a7b5102

@katspaugh katspaugh marked this pull request as draft November 13, 2023 12:30
Copy link

github-actions bot commented Nov 20, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Nov 20, 2023

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 1.39 MB (🟢 -8.6 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/apps/open 26.72 KB (-2 B) 1.42 MB
/balances 26.52 KB (🔴 +5.7 KB) 1.42 MB
/home 23.86 KB (-1 B) 1.41 MB
/welcome 7.13 KB (🟢 -1 B) 1.4 MB
/welcome/social-login 7.57 KB (🟡 +1 B) 1.4 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@katspaugh katspaugh marked this pull request as ready for review November 20, 2023 08:55
@liliya-soroka
Copy link
Member

do we know why https://verify.walletconnect.com/... 404 appears during dapp connection?
image

@liliya-soroka
Copy link
Member

I have the issues with wallet WC -

  1. can not sign
  2. errors in console on disconnect
    https://github.com/safe-global/safe-wallet-web/assets/338622/219dc251-3c04-414a-9727-00e1ae02f213

Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@katspaugh
Copy link
Member Author

Those 404 errors have been there since the beginning.

Regarding signing, what signer wallet are you using? Please make sure it supports Goerli, or try some other chain.

@liliya-soroka
Copy link
Member

Verified, mobile pairing info removed
connection via keystone, wc, MM works as before

@katspaugh katspaugh merged commit d019012 into dev Nov 20, 2023
15 checks passed
@katspaugh katspaugh deleted the rm-pairing branch November 20, 2023 15:11
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2023
@katspaugh katspaugh added this to the 1.23.0 milestone Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants