Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: disable copy & QR prefix if main setting is disabled #2796

Closed
wants to merge 1 commit into from

Conversation

katspaugh
Copy link
Member

What it solves

If the main EIP3770 setting is disabled, disable also the copying and scanning with prefixes.

Screenshot 2023-11-13 at 14 18 07

Copy link

github-actions bot commented Nov 13, 2023

Branch preview

✅ Deploy successful!

https://fix_prefix--walletweb.review-wallet-web.5afe.dev

Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 75.03% 10108/13472
🔴 Branches 49.52% 2054/4148
🔴 Functions 57.54% 1500/2607
🟡 Lines 76.59% 9143/11937

Test suite run success

1105 tests passing in 155 suites.

Report generated by 🧪jest coverage report action from 405b0fa

@katspaugh katspaugh closed this Nov 20, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2023
@katspaugh katspaugh deleted the fix-prefix branch December 13, 2023 08:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant