Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: prod build on staging (main) #2809

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Chore: prod build on staging (main) #2809

merged 1 commit into from
Nov 20, 2023

Conversation

katspaugh
Copy link
Member

What it solves

In order to be able to test our app with production settings before a release, we'll be building and deploying a production version on staging from the main branch.

With this setup, https://safe-wallet-web.staging.5afe.dev can be used as a close-to-prod environment for pre-release testing.

Copy link

github-actions bot commented Nov 14, 2023

Branch preview

✅ Deploy successful!

https://prod_build--walletweb.review-wallet-web.5afe.dev

Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 75.05% 10108/13469
🔴 Branches 49.59% 2055/4144
🔴 Functions 57.46% 1498/2607
🟡 Lines 76.62% 9144/11934

Test suite run success

1105 tests passing in 155 suites.

Report generated by 🧪jest coverage report action from 83f5b73

@francovenica
Copy link
Contributor

The only issue I had in this environment is that I cannot use social login because of an authorization error. I don't have this issue in the current staging env.

I'm not sure if this is because of this being a PR environment, or if if has to do with the setup done in this PR.
If it is the former, then I'm ok with approving this ticket
image

@katspaugh
Copy link
Member Author

@schmanu we need to whitelist the domain right?

@usame-algan
Copy link
Member

Yes this PR deployment is not whitelisted but since the branch name contains a - Google doesn't allow it to be whitelisted.

@katspaugh katspaugh merged commit 9727a41 into dev Nov 20, 2023
13 checks passed
@katspaugh katspaugh deleted the prod-build branch November 20, 2023 10:48
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2023
@katspaugh
Copy link
Member Author

https://safe-wallet-web.staging.5afe.dev/ needs to be white-listed, not this branch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants