-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: Cypress tests imrpovements #2816
Conversation
Branch preview✅ Deploy successful! https://cypress_test_improvements--walletweb.review-wallet-web.5afe.dev |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Three Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
Coverage report
Show files with reduced coverage 🔻
Test suite run success1105 tests passing in 155 suites. Report generated by 🧪jest coverage report action from 13104c6 |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
@@ -14,7 +14,7 @@ jobs: | |||
strategy: | |||
fail-fast: false | |||
matrix: | |||
containers: [1, 2, 3] | |||
containers: [1, 2, 3, 4, 5] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change? From what I see each container still runs for about 7 minutes. There's more overhead starting the machine than running the tests themselves.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@katspaugh we will be adding more tests to the suite. Adding more machines will reduce time spent on tests going forward.
name: Regression on demand tests | ||
|
||
on: | ||
workflow_dispatch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tested it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@katspaugh no, from what I understand it must be merged to dev first so the workflow is available
@@ -15,7 +15,7 @@ jobs: | |||
strategy: | |||
fail-fast: false | |||
matrix: | |||
containers: [1, 2, 3] | |||
containers: [1, 2] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another arbitrary change, what's the reasoning here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@katspaugh there are not many tests in safe apps, that's why reducing number of machines makes sense. As you said, there's more overhead starting the machine than running the tests themselves.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. Next time please try to limit the scope of your PRs and break them down into several, documented, PRs. This one mixes a lot of changes from tests themselves to CI settings across several workflows, and not everything is reflected in the PR description.
What it solves
Resolves #2814
How this PR fixes it