Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: delay the notifications banner #2823

Merged
merged 5 commits into from
Nov 21, 2023
Merged

Fix: delay the notifications banner #2823

merged 5 commits into from
Nov 21, 2023

Conversation

katspaugh
Copy link
Member

@katspaugh katspaugh commented Nov 20, 2023

What it solves

It was popping up too fast overlapping with the onboarding modal.

Screenshot 2023-11-20 at 11 20 38

How to test

  • Create a new Safe
  • Wait till it's indexed
  • Press the button to open the Safe
  • Observe the onboarding help modal
  • In 3 seconds, the notifications banner should appear

Copy link

github-actions bot commented Nov 20, 2023

Branch preview

✅ Deploy successful!

https://delay_banner--walletweb.review-wallet-web.5afe.dev

Copy link

github-actions bot commented Nov 20, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Nov 20, 2023

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.39 MB (🟡 +23 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Copy link

github-actions bot commented Nov 20, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.92% (+0% 🔼)
9983/13149
🔴 Branches
50.18% (+0.02% 🔼)
2035/4055
🔴 Functions 58.73% 1494/2544
🟡 Lines
77.5% (+0% 🔼)
9020/11639

Test suite run success

1095 tests passing in 154 suites.

Report generated by 🧪jest coverage report action from 3165deb

@liliya-soroka
Copy link
Member

liliya-soroka commented Nov 20, 2023

delay after click on X to close pop-up appears in the PR

Screen.Recording.2023-11-20.at.16.44.45.mov

@katspaugh
Copy link
Member Author

@liliya-soroka fixed, thanks! ✅

@katspaugh katspaugh added this to the 1.3.0 milestone Nov 21, 2023
@francovenica
Copy link
Contributor

LGTM.

Takes 3 secs to show up
The delay when closing the popUp is fixed (closes right away)
Tested with safe creation and safe addition.

@katspaugh katspaugh merged commit edc627a into dev Nov 21, 2023
15 checks passed
@katspaugh katspaugh deleted the delay-banner branch November 21, 2023 18:33
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants