Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Add Chrome version to smoke tests workflow #2826

Merged
merged 4 commits into from
Nov 22, 2023
Merged

Conversation

mike10ca
Copy link
Contributor

@mike10ca mike10ca commented Nov 20, 2023

What it solves

Resolves #2825

How this PR fixes it

Recently it was noticed that some machines started to fail when running Cypress tests in parallel. This was due to different version of Chrome passed by random machines, where Cypress requires all machines pass identical environment. The fix was to use specific version of Chrome and add this step to our test workflows.

Part of this task also included increasing number of test retries to reduce flaky tests. This will be observed and adjusted as needed.

Copy link

github-actions bot commented Nov 20, 2023

Branch preview

✅ Deploy successful!

https://add_chrome_version--walletweb.review-wallet-web.5afe.dev

Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Nov 20, 2023

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

github-actions bot commented Nov 20, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 75.96% 10019/13190
🔴 Branches 50.12% 2040/4070
🔴 Functions 58.76% 1496/2546
🟡 Lines 77.53% 9054/11678

Test suite run success

1098 tests passing in 154 suites.

Report generated by 🧪jest coverage report action from cf7a008

Copy link

github-actions bot commented Nov 22, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@mike10ca mike10ca marked this pull request as ready for review November 22, 2023 09:48
@katspaugh
Copy link
Member

More context on this for posterity:
GitHub regularly update their images, and there's no way to pin a specific version. 2 days ago was such an update that included a new Chrome version: actions/runner-images#8819

@mike10ca mike10ca merged commit 76484af into dev Nov 22, 2023
15 checks passed
@mike10ca mike10ca deleted the add-chrome-version branch November 22, 2023 10:43
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify Chrome version in automation tests
2 participants