fix: Add loading icons to buttons #2828
Conversation
Branch preview✅ Deploy successful! https://add_loading_icons--walletweb.review-wallet-web.5afe.dev |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
1.39 MB (🟡 +23 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Two Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/apps/open |
26.76 KB (🟡 +33 B) |
1.42 MB |
/transactions/queue |
19.14 KB (🟡 +33 B) |
1.41 MB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
Coverage report
Test suite run success1095 tests passing in 154 suites. Report generated by 🧪jest coverage report action from 01c0736 |
katspaugh
changed the title
|
This one isn't signed either. Please don't create duplicate PRs next time, you can simply force-push to replace your commits. |
francovenica
force-pushed
the
add-loading-icons
branch
from
b8db09e
to
f100dac
Compare
|
Nice, thank you! |
Note:
This ticket replaces #2805 for issues I had with signed commits. It seems is more trouble saving that ticket than just discard it and create this one.
The following description is a copy paste of what that ticket had originally
What it solves
When signing/executing for social login, since no popup shows up the user stays in the form for a few seconds not knowing if something is happening. I added a loading icon in the sign/execute button when clicked. The loading icon replaces the text to not messup with the buttons width
How this PR fixes it
Adds the icon when the button is grayed out (a tx is executing or being signed)
How to test it
The feature affects signing, execution and execution in bulk
Go to a form as an owner and click the sign/execute/submit, you sould see the loading icon replacing the text
Go to a form an disconnect. The button should NOT show the loading icon
Go to a form and switch to a non-owner. The button should NOT show the loading icon
Go to a fully sign tx with a non-owner. You SHOULD see the loading icon
Screenshots
Should look like this:
Checklist