Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: double scroll bar in safe apps #2829

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Fix: double scroll bar in safe apps #2829

merged 1 commit into from
Nov 21, 2023

Conversation

katspaugh
Copy link
Member

What it solves

Resolves #2827

How this PR fixes it

The iframe was inline-block which created an extra 6px space below it, causing an unnecessary scrollbar on the body.

Copy link

github-actions bot commented Nov 21, 2023

Branch preview

✅ Deploy successful!

https://fix_scroll--walletweb.review-wallet-web.5afe.dev

@@ -35,7 +35,6 @@ button {
:root {
--header-height: 52px;
--footer-height: 67px;
--import-export-widget-height: 166px;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't used anywhere.

Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 1.39 MB (-19 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/apps/open 26.72 KB (🟡 +3 B) 1.42 MB
/home 23.63 KB (🟡 +3 B) 1.41 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 75.92% 9981/13147
🔴 Branches 50.16% 2033/4053
🔴 Functions 58.73% 1494/2544
🟡 Lines 77.49% 9018/11637

Test suite run success

1095 tests passing in 154 suites.

Report generated by 🧪jest coverage report action from 665aea2

@katspaugh katspaugh merged commit 09a88f6 into dev Nov 21, 2023
15 checks passed
@katspaugh katspaugh deleted the fix-scroll branch November 21, 2023 09:02
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2023
@katspaugh katspaugh added this to the 1.23.0 milestone Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Hide iframe scrollbar by default
1 participant