Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Safe App share URL not always working #2830

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Fix: Safe App share URL not always working #2830

merged 2 commits into from
Nov 28, 2023

Conversation

katspaugh
Copy link
Member

@katspaugh katspaugh commented Nov 21, 2023

What it solves

Safe Apps share URL sometimes redirected to the home page due to a "race condition" when trying to read the chain from the URL.

I've removed the unnecessary chain-detecting logic and the redirect, relying on our existing useCurrentChain hook instead.

Caveat: if the wrong/non-supported chain is pasted in the URL (e.g. avax while on dev), it will result in an infinite loader. On prod, it would result in a redirect, which isn't much user-friendlier anyway.

How to test

The original bug happened randomly, so it's hard to reproduce. It's sufficient to test that share links still generally work.

Copy link

github-actions bot commented Nov 21, 2023

Branch preview

✅ Deploy successful!

https://fix_share--walletweb.review-wallet-web.5afe.dev

Copy link

github-actions bot commented Nov 21, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Nov 21, 2023

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/share/safe-app 9.28 KB (🟢 -165 B) 1.4 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Nov 21, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.89% (-0.03% 🔻)
9957/13121
🔴 Branches
50.09% (-0.07% 🔻)
2024/4041
🔴 Functions
58.66% (-0.06% 🔻)
1490/2540
🟡 Lines
77.46% (-0.04% 🔻)
8995/11613

Test suite run success

1095 tests passing in 154 suites.

Report generated by 🧪jest coverage report action from ad10b3a

@francovenica
Copy link
Contributor

I opened a bunch of apps using the share link in different networks and I didn't see the issue and worked fine.

I'll recheck in prod once deployed to check that the infinite loader doesn't happen

@katspaugh
Copy link
Member Author

To clarify, I meant that the current behavior on prod for unknown/bogus chains is to redirect to the index page.
After this PR, it will be an infinite loader.

@katspaugh katspaugh merged commit 75d7389 into dev Nov 28, 2023
15 checks passed
@katspaugh katspaugh deleted the fix-share branch November 28, 2023 10:23
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants