-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: recovery queue #2832
feat: recovery queue #2832
Conversation
Branch preview⏳ Deploying a preview site... |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success1193 tests passing in 168 suites. Report generated by 🧪jest coverage report action from 8da39d0 |
src/hooks/useTimestamp.ts
Outdated
@@ -0,0 +1,17 @@ | |||
import { useState, useEffect } from 'react' | |||
|
|||
export function useTimestamp(interval = 1_000): number { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would call this hook useClock
or useIntervalTimestamp
. useTimestamp
to me reads as a one-time timestamp.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've renamed it to useClock
in 6896ea6.
|
||
export const RecoveryInfo = (): ReactElement => { | ||
return ( | ||
<Tooltip title="This recovery attempt was not created via the interface" placement="top" arrow> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've renamed the transaction type to "Malicious transaction" (coloured in error.main
) and changed the tooltip to "Suspicious activity" in 6896ea6.
What it solves
Resolves #2763
How this PR fixes it
This implements a new "Pending recovery" section to the transaction queue which displays all recovery attempts from connected recovery-specific Delay Modifiers, as well as associated adjustments:
executor
andisMalicious
flags have been added, as well as all timestamps converted to ms)Note: text was tweaked and does not necessarily match the design. It is also not possible to skip recovery proposals yet. As such, queued recovery attempts and their "skip" transactions are not included in this PR.
How to test it
Screenshots
Old naming/colouring:
Checklist