feat: recovery info modals + widgets #2843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Nov 21, 2023
Branch preview✅ Deploy successful! https://recovery_modal_widgets--walletweb.review-wallet-web.5afe.dev |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Coverage report
Show new covered files 🐣
Test suite run success1212 tests passing in 171 suites. Report generated by 🧪jest coverage report action from 165c9d3 |
katspaugh
reviewed
Nov 22, 2023
Comment on lines
+52
to
+57
| export const RecoveryHeader = madProps(_RecoveryHeader, { | ||
| isOwner: useIsSafeOwner, | ||
| isGuardian: useIsGuardian, | ||
| supportsRecovery: _useSupportedRecovery, | ||
| queue: useRecoveryQueue, | ||
| }) |
katspaugh
reviewed
Nov 22, 2023
| ) | ||
| } | ||
|
|
||
| // Appease TypeScript |
There was a problem hiding this comment.
Is it because it wants to have a name?
There was a problem hiding this comment.
It complains about the rules of hooks as madProps is not a hook or component. I'd sooner extract it to a "middleman" hook than disabling the rule.
katspaugh
approved these changes
Nov 22, 2023
I've made @TanyaEfremova aware of this. I'm going to merge this in the mean time and we can revisit it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #2758 and #2759
How this PR fixes it
This adds full-screen modals that appear if/when a recovery proposal is either added to the queue (for an owner/guardian) or when none is queued (for guardian).
How to test it
Screenshots
Checklist