Release 1.23.0 #2846

katspaugh · 2023-11-22T11:58:35Z

📊 Analytics

Analytics: add Spindl (Analytics: add Spindl #2842)
Analytics: track tx creations and safe views (Analytics: track tx creations and safe views #2787)
Analytics: update Privacy policy for Spindl + refactor legal pages (Analytics: update Privacy policy for Spindl + refactor legal pages #2840)
Analytics: track wallet address (Analytics: track wallet address #2841)

🐞 Bug fixes

WalletConnect

Fix: separate WalletConnect storage (Fix: separate stored WalletConnect sessions #2793)
Fix: WC verification wording (Fix: WC verification wording #2798)

Other

fix: Update to new recommended nonce endpoint (fix: Update to new recommended nonce endpoint #2737)
fix: Add loading icons to buttons (fix: Add loading icons to buttons #2828)
Fix: delay the notifications banner (Fix: delay the notifications banner #2823)
Fix: double scroll bar in safe apps (Fix: double scroll bar in safe apps #2829)
Fix: add help link in footer (Fix: add help link in footer #2822)

🛠️ Improvements

Tests: Add Chrome version to smoke tests workflow (Tests: Add Chrome version to smoke tests workflow #2826)
Fix: remove deprecated mobile pairing (Fix: remove deprecated mobile pairing #2794)
Chore: replace ts-node with tsx (Chore: replace ts-node with tsx #2845)
Tests: Cypress tests imrpovements (Tests: Cypress tests imrpovements #2816)
Chore: prod build on staging (main) (Chore: prod build on staging (main) #2809)
Revert Dockerfile optimization (Chore: Revert Dockerfile optimization #2817)
Tests: Cypress seedless google flow (Tests: Cypress seedless google flow #2812)
fix: Lazy load mpc core kit (fix: Lazy load mpc core kit #2808)
chore: Analyze NextJS bundle size action (chore: Analyze NextJS bundle size action #2803)
Tests: Add test IDs and modify NFT tests (Tests: Add test IDs and modify NFT tests #2804)

* Add test IDs amd modify nft tests

* chore: Analyze NextJS bundle size action * fix: Remove redundant caching * fix: Remove working directory

* fix: Lazy load mpc core kit * fix: Only instantiate service once, extract address book function * fix: Add skeleton for socialSigner loading state * chore: Update bundle-analyzer action to update comment instead of creating new one

* Add seedless google flow happy path tests

- As environment variables are picked during build phase, we need to revert the dockerfile until we find a solution (it's better that the image takes 30 minutes to run that it doesn't work) - Build docker image for ARM64. That should make Apple computers run the image faster

* Update tests structure * Increase containers for parallel execution * Update workflows * Add test ids

* Fix: remove deprecated mobile pairing * Fix accounts[0] and Delete Account * Update onboard package * Update env vars

* Fix: add help link in footer * External link

* Fix: delay the notifications banner * Fix tests * Fix: close immediately

* fix:Add loading icons to buttons * commit with siganture * commit with siganture 2nd attempt

…2840) * Refactor: move legal pages from components to pages * Update privacy policy * Rm start={1} * Add pathnames * Section links * Smooth scroll

* Feat: track tx creations and safe views * Rm PROPOSE_TX, rename TOGGLE_EXECUTE_TX, fix SIMULATE_TX * Fix tests * Track only typed messages as tx_created * Safe viewed = meta event * Do not call onSubmit when adding to batch * Track safe apps tx creation * Analytics: track app version in all events (#2831) * Fix: remove deprecated mobile pairing (#2794) * Fix: remove deprecated mobile pairing * Fix accounts[0] and Delete Account * Update onboard package * Update env vars * Fix: add help link in footer (#2822) * Fix: add help link in footer * External link * Fix: double scroll bar in safe apps (#2829) * Feat: track app version in all events * Tests * Fix safeapps and walletconnect events * Rm spending_limit_transfer

* Add ability to use single Chrome version * Increase retry attempts

* Analytics: add Spindl * Env var * Init spindl

github-actions · 2023-11-22T11:58:48Z

Branch preview

⏳ Deploying a preview site...

github-actions · 2023-11-22T12:01:28Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

github-actions · 2023-11-22T12:05:31Z

Coverage report

St.^❔	Category	Percentage	Covered / Total
🟡	Statements	75.96% (+0.92% 🔼)	10020/13191
🔴	Branches	50.12% (+0.56% 🔼)	2040/4070
🔴	Functions	58.76% (+1.22% 🔼)	1496/2546
🟡	Lines	77.53% (+0.93% 🔼)	9055/11679

Show new covered files 🐣

St.^❔	File	Statements	Branches	Functions	Lines
🟢	`...` / transactions.ts	100%	100%	100%	100%

Show files with reduced coverage 🔻

St.^❔	File	Statements	Branches	Functions	Lines
🔴	`...` / Storage.ts	59.57% (-6.38% 🔻)	60%	40% (-10% 🔻)	57.78% (-6.67% 🔻)
🔴	`...` / useOnboard.ts	48.57% (-1.87% 🔻)	27.27% (+0.8% 🔼)	20%	50.56% (-2.02% 🔻)
🔴	`...` / dispatch.ts	49.3% (-0.35% 🔻)	61.11%	32%	48.12% (-0.36% 🔻)
🔴	`...` / recommendedNonce.ts	31.58% (-0.24% 🔻)	0%	0%	37.5% (+0.66% 🔼)
🔴	`...` / utils.ts	48.89% (-2.33% 🔻)	36.36%	26.67% (-1.9% 🔻)	50% (-1.72% 🔻)
🔴	`...` / SignForm.tsx	58.7% (-1.3% 🔻)	38.46% (-0.67% 🔻)	33.33%	59.09% (-1.37% 🔻)
🟢	`...` / ReviewSignMessageOnChain.tsx	82.26% (-2.22% 🔻)	50% (-8.82% 🔻)	80%	83.33% (-2.38% 🔻)
🟡	`...` / ReviewTokenTx.tsx	61.54% (-9.89% 🔻)	0%	0%	66.67% (-16.67% 🔻)
🔴	`...` / wallets.ts	34.62% (-0.57% 🔻)	0%	0%	43.9% (-0.28% 🔻)
🟢	`...` / WalletDetails.tsx	87.5% (-12.5% 🔻)	100%	0%	85.71% (-14.29% 🔻)

Test suite run success

1098 tests passing in 154 suites.

Report generated by 🧪jest coverage report action from 14570dd

- Add node-gyp before installing other packages - Increase yarn timeout

francovenica · 2023-11-23T02:31:20Z

The tickets that are functional in the description were checked and they work fine.
Keep going with the regression itself

francovenica · 2023-11-23T05:12:47Z

Indexing is not working properly in GNO, so I'll only use Sepolia
This is the safe I had issues with. I'll check again tomorrow to see if the indexing was successful:
gno:0x27325F57F06Ee951789aB1d37D8723031ff32cfc
I'm not receiving Notifications of any kind (incomming funds, tx to sign). Could it be because of the env?
In this PR I cannot use social login. Can we use stg after the setup we did? or we still have to whitelist?

The rest looks fine. I'll keep checking tomorrow a bit more

* Chore: reorganize workflow files * Extract Cypress job * Run checkout first * Shell: bash * Pass record key

mike10ca and others added 22 commits November 14, 2023 10:30

Tests: Add test IDs and modify NFT tests (#2804)

b356d75

* Add test IDs amd modify nft tests

chore: Analyze NextJS bundle size action (#2803)

34f1bae

* chore: Analyze NextJS bundle size action * fix: Remove redundant caching * fix: Remove working directory

fix: Lazy load mpc core kit (#2808)

a272500

* fix: Lazy load mpc core kit * fix: Only instantiate service once, extract address book function * fix: Add skeleton for socialSigner loading state * chore: Update bundle-analyzer action to update comment instead of creating new one

Tests: Cypress seedless google flow (#2812)

3598c18

* Add seedless google flow happy path tests

Chore: prod build on staging (main) (#2809)

9727a41

fix: Update to new recommended nonce endpoint (#2737)

ac480ec

Fix: WC verification wording (#2798)

0b5939c

Tests: Cypress tests imrpovements (#2816)

4cd3f3c

* Update tests structure * Increase containers for parallel execution * Update workflows * Add test ids

Fix: separate WalletConnect storage (#2793)

4a78e00

Fix: remove deprecated mobile pairing (#2794)

d019012

* Fix: remove deprecated mobile pairing * Fix accounts[0] and Delete Account * Update onboard package * Update env vars

Fix: add help link in footer (#2822)

82b0848

* Fix: add help link in footer * External link

Fix: double scroll bar in safe apps (#2829)

09a88f6

Fix: delay the notifications banner (#2823)

edc627a

* Fix: delay the notifications banner * Fix tests * Fix: close immediately

fix: Add loading icons to buttons (#2828)

985ccd7

* fix:Add loading icons to buttons * commit with siganture * commit with siganture 2nd attempt

Chore: replace ts-node with tsx (#2845)

0c367d2

Analytics: track wallet address (#2841)

21002ad

Analytics: update Privacy policy for Spindl + refactor legal pages (#…

9a7978c

…2840) * Refactor: move legal pages from components to pages * Update privacy policy * Rm start={1} * Add pathnames * Section links * Smooth scroll

Tests: Add Chrome version to smoke tests workflow (#2826)

76484af

* Add ability to use single Chrome version * Increase retry attempts

Analytics: add Spindl (#2842)

d81cd0c

* Analytics: add Spindl * Env var * Init spindl

v1.23.0

5cfb854

katspaugh changed the title ~~Release/1.23.0~~ Release 1.23.0 Nov 22, 2023

katspaugh requested review from francovenica and liliya-soroka November 22, 2023 12:53

Chore: fix ARM64 docker image build (#2847)

56fe78e

- Add node-gyp before installing other packages - Increase yarn timeout

katspaugh and others added 5 commits November 23, 2023 07:39

Analytics: add a Confirm transaction event (#2849)

14570dd

Tests: Add tests schedule (#2857)

5ff9855

Chore: reorganize CI workflow files (#2854)

68ee9b1

* Chore: reorganize workflow files * Extract Cypress job * Run checkout first * Shell: bash * Pass record key

Tests: Add TestRail integration to CI (#2860)

0d20217

Fix: tracking onchain signatures condition

d06ff30

katspaugh closed this pull request by merging all changes into main in d06ff30 Nov 23, 2023

katspaugh deleted the release/1.23.0 branch November 23, 2023 10:17

github-actions bot locked and limited conversation to collaborators Nov 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 1.23.0 #2846

Release 1.23.0 #2846

katspaugh commented Nov 22, 2023 •

edited

Loading

github-actions bot commented Nov 22, 2023 •

edited

Loading

github-actions bot commented Nov 22, 2023 •

edited

Loading

github-actions bot commented Nov 22, 2023 •

edited

Loading

francovenica commented Nov 23, 2023

francovenica commented Nov 23, 2023

Release 1.23.0 #2846

Release 1.23.0 #2846

Conversation

katspaugh commented Nov 22, 2023 • edited Loading

📊 Analytics

🐞 Bug fixes

WalletConnect

Other

🛠️ Improvements

github-actions bot commented Nov 22, 2023 • edited Loading

Branch preview

github-actions bot commented Nov 22, 2023 • edited Loading

ESLint Summary View Full Report

github-actions bot commented Nov 22, 2023 • edited Loading

Coverage report

Test suite run success

francovenica commented Nov 23, 2023

francovenica commented Nov 23, 2023

katspaugh commented Nov 22, 2023 •

edited

Loading

github-actions bot commented Nov 22, 2023 •

edited

Loading

github-actions bot commented Nov 22, 2023 •

edited

Loading

github-actions bot commented Nov 22, 2023 •

edited

Loading