Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics: add a Confirm transaction event #2849

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Analytics: add a Confirm transaction event #2849

merged 1 commit into from
Nov 23, 2023

Conversation

katspaugh
Copy link
Member

@katspaugh katspaugh commented Nov 22, 2023

What it solves

In #2787, we added a new event Create transaction. Since a signature is required for both tx creation and confirmation, we cannot use the existing Off-chain signature event to track signatures for existing transactions.
So I've added another event, Confirm transaction to track specifically those kind of signatures.

Copy link

github-actions bot commented Nov 22, 2023

Branch preview

✅ Deploy successful!

https://fix_sign--walletweb.review-wallet-web.5afe.dev

@katspaugh katspaugh marked this pull request as draft November 22, 2023 16:42
Copy link

github-actions bot commented Nov 22, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@katspaugh katspaugh changed the title Analytics: fix off-chain signature event Analytics: add a Confirm transaction event Nov 22, 2023
Copy link

github-actions bot commented Nov 22, 2023

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.4 MB (🟡 +21 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@katspaugh katspaugh marked this pull request as ready for review November 22, 2023 16:46
Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.96% (+0% 🔼)
10020/13191
🔴 Branches 50.12% 2040/4070
🔴 Functions 58.76% 1496/2546
🟡 Lines
77.53% (+0% 🔼)
9055/11679

Test suite run success

1098 tests passing in 154 suites.

Report generated by 🧪jest coverage report action from 3a9ccf5

@katspaugh
Copy link
Member Author

Verified:
Screenshot 2023-11-23 at 07 38 37

@katspaugh katspaugh merged commit 14570dd into dev Nov 23, 2023
15 checks passed
@katspaugh katspaugh deleted the fix-sign branch November 23, 2023 06:39
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant