-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Sygnum safe app recovery method [SW-168] #4166
Conversation
Branch preview✅ Deploy successful! Website: Storybook: |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! Forty-one Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
Coverage report
Show files with reduced coverage 🔻
Test suite run success1483 tests passing in 203 suites. Report generated by 🧪jest coverage report action from 459693b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Looks good!
the ticket is moved back with questions https://www.notion.so/safe-global/Tweak-Recovery-Hub-UI-with-Sygnum-being-live-1b5bde2ee7a841568f05962d9d02c634?pvs=4 |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
@liliya-soroka fixed ✅ |
Can we adjust the style of the card according to design, please? See Figma |
Disable the Sygnum option if app is not enabled
ESLint Summary View Full Report
Report generated by eslint-plus-action |
What it solves
Resolves https://www.notion.so/safe-global/Tweak-Recovery-Hub-UI-with-Sygnum-being-live-1b5bde2ee7a841568f05962d9d02c634
How this PR fixes it
Sygnum Safe App will be released soon, so it becomes an active recovery option and not a waitlist.
How to test it
Checklist