Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: stake dashboard widget #4192

Closed
wants to merge 7 commits into from
Closed

Conversation

compojoom
Copy link
Collaborator

@compojoom compojoom commented Sep 17, 2024

What it solves

Ads a Stake widget, but this is not ready. We currently can't pass url arguments to hide the navbar, or to make the widget fullscreen.

Resolves #

How this PR fixes it

How to test it

Screenshots

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Sep 17, 2024

@compojoom compojoom changed the base branch from dev to fix-stake-miscellanious September 17, 2024 14:22
Copy link

github-actions bot commented Sep 17, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Sep 17, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 940.08 KB (🟢 -335 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Fourteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/apps 49.24 KB (🟢 -953 B) 989.32 KB
/apps/custom 40.87 KB (🟢 -948 B) 980.95 KB
/balances 30.98 KB (🟡 +346 B) 971.06 KB
/balances/nfts 18.16 KB (🟢 -1 KB) 958.24 KB
/home 85.73 KB (🔴 +25.48 KB) 1 MB
/new-safe/advanced-create 35.19 KB (🟡 +48 B) 975.27 KB
/new-safe/create 34.45 KB (🟡 +47 B) 974.53 KB
/settings/cookies 7.64 KB (🟡 +1 B) 947.72 KB
/settings/data 7.54 KB (🟡 +1 B) 947.62 KB
/settings/safe-apps 25.55 KB (🟡 +2 B) 965.63 KB
/settings/security 8.06 KB (🟡 +1 B) 948.14 KB
/settings/setup 35.96 KB (🟡 +2 B) 976.04 KB
/terms 11.24 KB (🟡 +60 B) 951.32 KB
/transactions/queue 31.22 KB (🟡 +1 B) 971.3 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@compojoom compojoom force-pushed the feat-stake-dashboard-widget branch 2 times, most recently from 9d46a46 to d93290e Compare September 17, 2024 14:27
Copy link

github-actions bot commented Sep 17, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
78.24% (+0.01% 🔼)
11987/15320
🔴 Branches
58.15% (+0.02% 🔼)
3058/5259
🟡 Functions 65.33% 1890/2893
🟡 Lines
79.76% (+0.01% 🔼)
10822/13569

Test suite run success

1484 tests passing in 203 suites.

Report generated by 🧪jest coverage report action from 1f48e84

Base automatically changed from fix-stake-miscellanious to dev September 19, 2024 08:18
@compojoom
Copy link
Collaborator Author

closign this as we decided to follow a different approach. @tmjssz is going to do a new pr.

@compojoom compojoom closed this Oct 9, 2024
@compojoom compojoom deleted the feat-stake-dashboard-widget branch October 9, 2024 15:04
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant