Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Multichain] fix: check for canonical deployments #4193

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

schmanu
Copy link
Member

@schmanu schmanu commented Sep 17, 2024

What it solves

Fixes the check for canonical deployments in the NetworkMultiSelector

How to test it

  • Create a new Safe and start with any chain except zkSync.
  • Observe that now zkSync is not offered (greyed out)

Screenshots

Screenshot 2024-09-17 at 18 27 53

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@schmanu schmanu changed the title fix: check for canonical deployments [Multichain] fix: check for canonical deployments Sep 17, 2024
@schmanu schmanu requested a review from jmealy September 17, 2024 16:31
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 979.14 KB (🟡 +38.73 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Nineteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 507 B (🟢 -24.36 KB) 979.63 KB
/address-book 26.11 KB (🟡 +3 B) 1005.25 KB
/apps/open 54.74 KB (🟡 +1 B) 1.01 MB
/balances 30.64 KB (-3 B) 1009.78 KB
/home 60.28 KB (🟡 +31 B) 1.02 MB
/new-safe/advanced-create 36.51 KB (🟡 +1.36 KB) 1015.65 KB
/new-safe/create 35.76 KB (🟡 +1.35 KB) 1014.9 KB
/new-safe/load 16.38 KB (🟢 -7 B) 995.52 KB
/settings/modules 9.76 KB (🟢 -1 B) 988.9 KB
/settings/setup 35.96 KB (🟡 +1 B) 1015.09 KB
/share/safe-app 9.72 KB (🟢 -2 B) 988.86 KB
/terms 11.24 KB (🟡 +60 B) 990.38 KB
/transactions 73.47 KB (🟡 +1 B) 1.03 MB
/transactions/history 73.44 KB (🟡 +1 B) 1.03 MB
/transactions/messages 39.12 KB (-1 B) 1018.26 KB
/transactions/msg 29.5 KB (-1 B) 1008.64 KB
/transactions/queue 31.22 KB (🟡 +1 B) 1010.36 KB
/transactions/tx 21.05 KB (🟡 +1 B) 1000.19 KB
/welcome 6.77 KB (🟢 -1 B) 985.91 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
77.88% (-0.04% 🔻)
12312/15809
🔴 Branches
57.97% (-0.03% 🔻)
3179/5484
🟡 Functions
65.04% (-0.07% 🔻)
1933/2972
🟡 Lines
79.35% (-0.02% 🔻)
11116/14008
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / deployments.ts
81.13% (-14.11% 🔻)
75% (-25% 🔻)
69.23% (-20.77% 🔻)
85% (-11.88% 🔻)

Test suite run success

1525 tests passing in 206 suites.

Report generated by 🧪jest coverage report action from 542e3d8

@schmanu schmanu merged commit 99b0cb1 into epic/multichain-safes Sep 19, 2024
14 checks passed
@schmanu schmanu deleted the fix/multichain-canonical-check branch September 19, 2024 08:15
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants