Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Multichain] Fix: Disable legacy safe replaying #4197

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

schmanu
Copy link
Member

@schmanu schmanu commented Sep 18, 2024

What it solves

Legacy Safes could be replayed through the sidebar context menu.

How this PR fixes it

Marks unavailable chains as disabled

How to test it

  • Try to add a network to a 1.1.1 Safe

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 979.16 KB (🟡 +39.63 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Forty-one Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 507 B (🟢 -24.38 KB) 979.65 KB
/403 574 B (🟢 -3 B) 979.72 KB
/404 697 B (🟢 -1 B) 979.84 KB
/_error 230 B (🟡 +2 B) 979.38 KB
/_offline 1.09 KB (🟢 -3 B) 980.25 KB
/addOwner 535 B (🟡 +1 B) 979.68 KB
/address-book 26.11 KB (🟡 +17 B) 1005.27 KB
/apps 50.17 KB (🟢 -17 B) 1.01 MB
/apps/bookmarked 446 B (🟡 +1 B) 979.59 KB
/apps/custom 41.79 KB (🟢 -26 B) 1020.95 KB
/apps/open 54.74 KB (🟡 +12 B) 1.01 MB
/balances 30.64 KB (🟢 -26 B) 1009.8 KB
/balances/nfts 19.16 KB (🟢 -23 B) 998.32 KB
/cookie 8.76 KB (🟡 +27 B) 987.92 KB
/home 60.28 KB (🟡 +68 B) 1.02 MB
/imprint 1.38 KB (🟡 +2 B) 980.53 KB
/licenses 4.97 KB (🟢 -3 B) 984.13 KB
/new-safe/advanced-create 36.52 KB (🟡 +1.37 KB) 1015.68 KB
/new-safe/create 35.77 KB (🟡 +1.36 KB) 1014.93 KB
/new-safe/load 16.38 KB (🟢 -34 B) 995.54 KB
/privacy 15.9 KB (🟡 +24 B) 995.05 KB
/settings/appearance 8.02 KB (🟢 -21 B) 987.18 KB
/settings/cookies 7.64 KB (🟢 -27 B) 986.79 KB
/settings/data 7.54 KB (🟢 -24 B) 986.7 KB
/settings/environment-variables 9.13 KB (🟢 -26 B) 988.28 KB
/settings/modules 9.76 KB (🟢 -21 B) 988.92 KB
/settings/notifications 27.85 KB (🟡 +833 B) 1007.01 KB
/settings/safe-apps 25.55 KB (🟢 -14 B) 1004.71 KB
/settings/security 8.06 KB (🟢 -24 B) 987.22 KB
/settings/setup 35.96 KB (🟢 -28 B) 1015.11 KB
/share/safe-app 9.72 KB (🟢 -2 B) 988.88 KB
/stake 589 B (🟢 -12 B) 979.73 KB
/swap 723 B (🟢 -7 B) 979.86 KB
/terms 11.24 KB (🟡 +57 B) 990.4 KB
/transactions 73.47 KB (🟢 -51 B) 1.03 MB
/transactions/history 73.44 KB (🟢 -53 B) 1.03 MB
/transactions/messages 39.12 KB (🟢 -41 B) 1018.28 KB
/transactions/msg 29.5 KB (🟢 -11 B) 1008.66 KB
/transactions/queue 31.22 KB (🟢 -38 B) 1010.38 KB
/transactions/tx 21.05 KB (🟢 -8 B) 1000.21 KB
/welcome 6.77 KB (🟢 -6 B) 985.92 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
77.93% (+0.02% 🔼)
12312/15798
🔴 Branches
58.02% (+0.02% 🔼)
3180/5481
🟡 Functions
65.14% (+0.03% 🔼)
1934/2969
🟡 Lines
79.4% (+0.02% 🔼)
11116/14000

Test suite run success

1524 tests passing in 206 suites.

Report generated by 🧪jest coverage report action from 1a54825

@schmanu schmanu merged commit 938d524 into epic/multichain-safes Sep 18, 2024
14 checks passed
@schmanu schmanu deleted the fix/disable-legacy-safe-replaying branch September 18, 2024 12:24
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants