Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(Staking): add tooltip to widget fee #4204

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Fix(Staking): add tooltip to widget fee #4204

merged 1 commit into from
Sep 19, 2024

Conversation

compojoom
Copy link
Collaborator

What it solves

The fee label for deposit was missing the Info tooltip. This PR ads it.

How to test it

Try to create a deposit, the fee tooltip should be next to the fee.

Screenshots

grafik

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Sep 19, 2024

Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 954.21 KB (🟡 +279 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Copy link

github-actions bot commented Sep 19, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
78.23% (-0% 🔻)
12013/15356
🔴 Branches 58.2% 3081/5294
🟡 Functions
65.27% (-0.02% 🔻)
1891/2897
🟡 Lines
79.75% (-0% 🔻)
10845/13599
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟡
... / index.tsx
66.67% 100% 0% 66.67%

Test suite run success

1485 tests passing in 203 suites.

Report generated by 🧪jest coverage report action from 1965ef3

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some unrelated unit tests seem to be failing.

@katspaugh katspaugh changed the title fix: add tooltip to widget fee Fix(Staking): add tooltip to widget fee Sep 19, 2024
@compojoom compojoom merged commit bbf9f90 into dev Sep 19, 2024
16 checks passed
@compojoom compojoom deleted the fix-widget-fee-info branch September 19, 2024 09:36
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants