Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: unify confirmBatch screen #4217

Conversation

clovisdasilvaneto
Copy link
Contributor

What it solves

This PR is part of the unify confirmations screen refactor in the transactions flow (#4177).

How this PR fixes it

In this PR we're moving the BatchList from ConfirmBatch component to be inside the tx/confirmation-view/BatchTransactions component. Please noticed we still have logic inside the ConfirmBatch component because the SignOrExecuteForm/index depends on the SafeTx in order to get the transactionDetails, and the place where we create the SafeTx for the Batch screen is inside the ConfirmBatch component.

How to test it

  1. Go to the top bar of the application and try to send a batch transaction
  2. The confirm batch transaction screen should look the same as production app.

Screenshots

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 1 0
Ignored 0 N/A
  • Result: ✅ success

  • Annotations: 1 total


[warning] react-hooks/exhaustive-deps

verifies the list of dependencies for Hooks like useEffect and similar


Report generated by eslint-plus-action

Copy link

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 954.34 KB (🟡 +97 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/balances 30.99 KB (-1 B) 985.32 KB
/home 60.21 KB (-4 B) 1014.55 KB
/swap 733 B (🟡 +1 B) 955.05 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
78.61% (+0.14% 🔼)
12211/15534
🔴 Branches
59.15% (+0.12% 🔼)
3158/5339
🟡 Functions
65.9% (+0.15% 🔼)
1929/2927
🟢 Lines
80.08% (+0.12% 🔼)
11012/13751
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / index.tsx
100% 100% 100% 100%
🟢
... / BatchTxList.tsx
100% 100% 100% 100%
🟡
... / BatchTxItem.tsx
79.17% 71.43% 50% 78.26%
🟢
... / utils.ts
100% 100% 100% 100%
🟢
... / mockData.ts
100% 100% 100% 100%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / index.tsx
92.31% (-3.15% 🔻)
52.38% (-6.71% 🔻)
100% 100%
🟢
... / useTxPendingStatuses.ts
83.64% (-0.91% 🔻)
68.33% (-1.67% 🔻)
75%
92.63% (-1.05% 🔻)

Test suite run success

1494 tests passing in 208 suites.

Report generated by 🧪jest coverage report action from 86f3947

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but there's one lint issue

@katspaugh katspaugh changed the title chore: unify confirmBatch screen Refactor: unify confirmBatch screen Sep 27, 2024
@clovisdasilvaneto clovisdasilvaneto merged commit f3d527b into chore/refactor-transaction-flow Oct 18, 2024
1 check passed
@clovisdasilvaneto clovisdasilvaneto deleted the chore/unify-confirm-batch-screen branch October 18, 2024 07:53
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants