-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: unify confirmBatch screen #4217
Refactor: unify confirmBatch screen #4217
Conversation
Branch preview✅ Deploy successful! Storybook: |
ESLint Summary View Full Report
[warning] react-hooks/exhaustive-deps
Report generated by eslint-plus-action |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
Page | Size (compressed) |
---|---|
global |
954.34 KB (🟡 +97 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Three Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
Page | Size (compressed) | First Load |
---|---|---|
/balances |
30.99 KB (-1 B) |
985.32 KB |
/home |
60.21 KB (-4 B) |
1014.55 KB |
/swap |
733 B (🟡 +1 B) |
955.05 KB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link
is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success1494 tests passing in 208 suites. Report generated by 🧪jest coverage report action from 86f3947 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but there's one lint issue
f3d527b
into
chore/refactor-transaction-flow
What it solves
This PR is part of the unify confirmations screen refactor in the transactions flow (#4177).
How this PR fixes it
In this PR we're moving the
BatchList
fromConfirmBatch
component to be inside thetx/confirmation-view/BatchTransactions
component. Please noticed we still have logic inside theConfirmBatch
component because theSignOrExecuteForm/index
depends on the SafeTx in order to get the transactionDetails, and the place where we create the SafeTx for the Batch screen is inside theConfirmBatch
component.How to test it
Screenshots
Checklist