Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Multichain] fix: Pass options for safe creation [SW-199] #4234

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Sep 23, 2024

What it solves

Resolves SW-199

How this PR fixes it

  • Passes options to createNewSafe
  • Adds the saltNonce to newSafeProps to avoid spreading which causes a lot of requests
  • Removes unused code

How to test it

Screenshots

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Sep 23, 2024

Copy link

Copy link

github-actions bot commented Sep 23, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Sep 23, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 991.13 KB (🟡 +36.62 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Thirteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 511 B (🟢 -24.37 KB) 991.63 KB
/address-book 26.1 KB (🟡 +1 B) 1017.23 KB
/apps/open 54.74 KB (-1 B) 1.02 MB
/balances 31 KB (🟡 +16 B) 1022.14 KB
/balances/nfts 19.18 KB (-1 B) 1010.31 KB
/home 60.89 KB (🟡 +687 B) 1.03 MB
/new-safe/advanced-create 36.39 KB (🟡 +1.25 KB) 1 MB
/new-safe/create 35.65 KB (🟡 +1.24 KB) 1 MB
/new-safe/load 16.42 KB (🟡 +6 B) 1007.55 KB
/settings/setup 35.98 KB (-2 B) 1 MB
/transactions 73.52 KB (-2 B) 1.04 MB
/transactions/history 73.49 KB (-2 B) 1.04 MB
/transactions/tx 21.07 KB (-1 B) 1012.2 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link
Member

@schmanu schmanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the safe creation fix on top of this!

Copy link

github-actions bot commented Sep 23, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
78.07% (+0.02% 🔼)
12428/15919
🔴 Branches
57.98% (+0.02% 🔼)
3212/5540
🟡 Functions
65.3% (+0.05% 🔼)
1955/2994
🟡 Lines
79.57% (+0.02% 🔼)
11214/14093

Test suite run success

1540 tests passing in 206 suites.

Report generated by 🧪jest coverage report action from 11c3f28

@usame-algan usame-algan merged commit caf5b96 into epic/multichain-safes Sep 23, 2024
13 checks passed
@usame-algan usame-algan deleted the pass-options branch September 23, 2024 14:53
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants