Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(Multichain): Keep focus within text input when typing name in replay modal [SW-205] #4237

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

jmealy
Copy link
Contributor

@jmealy jmealy commented Sep 23, 2024

What it solves

When typing some letters in the name input within the replay safe modal, the focus is moved away from the input.
Related: mui/material-ui#19116

How this PR fixes it

Stops keyboard events in the text input.

How to test it

  • Open a multichain safe.
  • In the network selector, open the modal to replay the safe on another chain
  • In the text input for setting the name, highlight the existing text and start typing. No matter what letter you start with, it should type as expected. (problematic letters were s, e, and p)

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Sep 23, 2024

@jmealy jmealy marked this pull request as draft September 23, 2024 14:43
Copy link

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 991.36 KB (🟡 +36.85 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Thirteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 511 B (🟢 -24.37 KB) 991.86 KB
/address-book 26.1 KB (🟡 +1 B) 1017.46 KB
/apps/open 54.74 KB (-1 B) 1.02 MB
/balances 31 KB (🟡 +16 B) 1022.36 KB
/balances/nfts 19.18 KB (-1 B) 1010.54 KB
/home 60.89 KB (🟡 +687 B) 1.03 MB
/new-safe/advanced-create 36.39 KB (🟡 +1.25 KB) 1 MB
/new-safe/create 35.65 KB (🟡 +1.24 KB) 1 MB
/new-safe/load 16.42 KB (🟡 +6 B) 1007.78 KB
/settings/setup 35.98 KB (-2 B) 1 MB
/transactions 73.52 KB (-2 B) 1.04 MB
/transactions/history 73.49 KB (-2 B) 1.04 MB
/transactions/tx 21.07 KB (-1 B) 1012.43 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
78.05% (-0.03% 🔻)
12425/15919
🔴 Branches
57.98% (-0.1% 🔻)
3212/5540
🟡 Functions
65.23% (-0.05% 🔻)
1953/2994
🟡 Lines
79.55% (-0.01% 🔻)
11211/14093
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / deployments.ts
81.13% (-4.35% 🔻)
75% (-11.67% 🔻)
69.23% (-12.02% 🔻)
85% (-2.23% 🔻)
🔴
... / utils.ts
44.85% (-1.21% 🔻)
38.78% (-2.04% 🔻)
38.46% (-3.85% 🔻)
45.77% (-0.7% 🔻)
🟢
... / useSafeCreationData.ts
96.97% (-1.6% 🔻)
87.5% (-7.95% 🔻)
100%
98.41% (-1.59% 🔻)
🟢
... / index.tsx
90% (-10% 🔻)
57.14%
50% (-50% 🔻)
88.89% (-11.11% 🔻)

Test suite run success

1540 tests passing in 206 suites.

Report generated by 🧪jest coverage report action from 8f477db

@jmealy jmealy marked this pull request as ready for review September 23, 2024 15:16
Copy link
Member

@schmanu schmanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. Good find!

@jmealy jmealy merged commit 8679c93 into epic/multichain-safes Sep 24, 2024
13 checks passed
@jmealy jmealy deleted the Fix/Multichain-text-focus branch September 24, 2024 07:39
@github-actions github-actions bot locked and limited conversation to collaborators Sep 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants