Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(Multichain): use wallet network as default for safe creation [SW-215] #4241

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

jmealy
Copy link
Contributor

@jmealy jmealy commented Sep 24, 2024

What it solves

Resolves: https://www.notion.so/safe-global/Default-selected-network-for-safe-creation-is-confusing-after-hiding-Network-switcher-10a8180fe57380869a80eca157865b6c?pvs=4

How this PR fixes it

  • Uses wallet network as default for safe creation multiselect input.
  • Syncs wallet network and current network to prevent a network switch prompt in the wallet info modal

How to test it

  • When beginning the safe creation flow, the default network shown in the multiselect input should always match the connected wallet network.

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Sep 24, 2024

@jmealy jmealy changed the base branch from dev to epic/multichain-safes September 24, 2024 10:11
Copy link

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 991.38 KB (🟡 +36.87 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Thirteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 511 B (🟢 -24.37 KB) 991.88 KB
/address-book 26.1 KB (🟡 +1 B) 1017.48 KB
/apps/open 54.74 KB (-1 B) 1.02 MB
/balances 31 KB (🟡 +16 B) 1022.38 KB
/balances/nfts 19.18 KB (-1 B) 1010.56 KB
/home 60.89 KB (🟡 +687 B) 1.03 MB
/new-safe/advanced-create 36.48 KB (🟡 +1.33 KB) 1 MB
/new-safe/create 35.74 KB (🟡 +1.33 KB) 1 MB
/new-safe/load 16.42 KB (🟡 +6 B) 1007.8 KB
/settings/setup 35.98 KB (-2 B) 1 MB
/transactions 73.52 KB (-2 B) 1.04 MB
/transactions/history 73.49 KB (-2 B) 1.04 MB
/transactions/tx 21.07 KB (-1 B) 1012.45 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
78.07% (-0.16% 🔻)
12433/15925
🔴 Branches
58.06% (-0.15% 🔻)
3222/5549
🟡 Functions
65.27% (-0.01% 🔻)
1953/2992
🟡 Lines
79.56% (-0.19% 🔻)
11215/14097
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / multiChainSafe.ts
98.48% 96% 100% 100%
🟢
... / useSafeCreationData.ts
98.57% 95.45% 100% 100%
🟢
... / useCompatibleNetworks.ts
100% 100% 100% 100%
🔴
... / index.tsx
38.1% 0% 0% 39.02%
🟢
... / MigrateToL2Information.tsx
80% 0% 0% 100%
🟢
... / utils.ts
100% 100% 100% 100%
🟡
... / ChangeSignerSetupWarning.tsx
50% 0% 0% 62.5%
🔴
... / useIsMultichainSafe.ts
45.45% 100% 0% 55.56%
🔴
... / useAllSafesGrouped.ts
23.81% 0% 0% 27.78%
🔴
... / useAllSafes.ts
50% 17.24% 37.5% 55.56%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / transaction-guards.ts
68.08% (-1.67% 🔻)
33.33% (-3.59% 🔻)
68.25% (-0.08% 🔻)
68.67% (-2.44% 🔻)
🟢
... / deployments.ts
85.48% (-14.52% 🔻)
86.67% (-13.33% 🔻)
81.25% (-18.75% 🔻)
87.23% (-12.77% 🔻)
🟢
... / safeCoreSDK.ts
92.31% (-3.61% 🔻)
84.62% (-7.05% 🔻)
100%
93.48% (-4.2% 🔻)
🟢 src/store/common.ts
88.89% (-11.11% 🔻)
50%
75% (-25% 🔻)
84.62% (-15.38% 🔻)
🟡
... / addedSafesSlice.ts
65.52% (+2.36% 🔼)
75% (+25% 🔼)
33.33% (-8.33% 🔻)
68.18% (+0.44% 🔼)
🔴
... / undeployedSafesSlice.ts
38.46% (+1.32% 🔼)
33.33%
30% (-7.5% 🔻)
42.86% (-1.14% 🔻)
🔴
... / SafeTxProvider.tsx
28.95% (+0.38% 🔼)
0%
40% (-4.44% 🔻)
29.41% (+0.25% 🔼)
🟢
... / index.tsx
86.05% (-1.45% 🔻)
37.14% (-1.09% 🔻)
42.86% (-7.14% 🔻)
85.37% (-1.48% 🔻)
🟢
... / index.tsx
95.45% (-4.55% 🔻)
50% (-16.67% 🔻)
100%
95.24% (-4.76% 🔻)
🟢
... / index.tsx
90% (-10% 🔻)
57.14%
50% (-50% 🔻)
88.89% (-11.11% 🔻)
🟢
... / utils.ts
92.59% (-7.41% 🔻)
75% (-25% 🔻)
100%
91.67% (-8.33% 🔻)
🟢
... / index.ts
94.74% (-0.72% 🔻)
75% (+8.33% 🔼)
100% 100%
🟡
... / index.tsx
72.73% (-10.61% 🔻)
0% 0%
70% (-10% 🔻)
🟡
... / index.tsx
63.16% (-2.91% 🔻)
47.37% (+2.37% 🔼)
58.82% (-2.71% 🔻)
63.71% (-2.33% 🔻)
🟢
... / useSafeOverviews.ts
96.55% (-3.45% 🔻)
85.71% (-14.29% 🔻)
100%
95.83% (-4.17% 🔻)

Test suite run success

1543 tests passing in 206 suites.

Report generated by 🧪jest coverage report action from 95d7a2b

@jmealy jmealy merged commit 11754e1 into epic/multichain-safes Sep 24, 2024
15 checks passed
@jmealy jmealy deleted the fix-default-network branch September 24, 2024 13:41
@github-actions github-actions bot locked and limited conversation to collaborators Sep 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants