Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: rm WC/TxB from dashboard - make space for recent Safe Apps #4248

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

katspaugh
Copy link
Member

What it solves

The recently used Safe Apps block on the Dashboard is pushed below the fold by preceding blocks making it not discoverable.

Since the "Connect & Transact" block is largely redundant (Tx Builder is linked from New Transaction, WalletConnect has a button in the header), it makes more sense to remove it and push the Safe Apps block up.

Screenshot 2024-09-25 at 12 02 36

See the original discussion on slack.

Screenshots

Screenshot 2024-09-25 at 12 04 07

Copy link

github-actions bot commented Sep 25, 2024

Copy link
Member

@usame-algan usame-algan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link

github-actions bot commented Sep 25, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 954.48 KB (-49 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/apps 50.01 KB (🟢 -174 B) 1004.49 KB
/apps/custom 41.64 KB (🟢 -174 B) 996.12 KB
/apps/open 54.7 KB (🟢 -38 B) 1009.18 KB
/home 59.72 KB (🟢 -522 B) 1014.21 KB
/settings/safe-apps 25.53 KB (🟢 -38 B) 980.01 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Sep 25, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
78.21% (-0.02% 🔻)
11991/15332
🔴 Branches 58.25% 3086/5298
🟡 Functions
65.27% (-0.04% 🔻)
1889/2894
🟡 Lines
79.72% (-0.02% 🔻)
10822/13575

Test suite run success

1484 tests passing in 203 suites.

Report generated by 🧪jest coverage report action from 632ba4b

@francovenica
Copy link
Contributor

LGTM

@katspaugh katspaugh merged commit 61c78ed into dev Sep 26, 2024
15 checks passed
@katspaugh katspaugh deleted the dashboard branch September 26, 2024 06:25
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants