-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(staking): display stake statuses & exit & claim "values" #4249
Conversation
Branch preview✅ Deploy successful! Storybook: |
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success1484 tests passing in 203 suites. Report generated by 🧪jest coverage report action from e7e6ab7 |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
Page | Size (compressed) |
---|---|
global |
954.79 KB (🟡 +167 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Revert "fix: small UI discrepancies with the figma designs" This reverts commit 1efbf952c130cdfa856988952ed1489fe079626a.
The gateway now returns the time in milliseconds.
Instead of displaying the value for exiting a validator, we now display the validator amount that we are exiting.
b0ed5e4
to
e7e6ab7
Compare
What it solves
How this PR fixes it
Status Display Corrections:
Updated the StakingStatus component to correctly map staking statuses to their corresponding display texts and icons.
Modified status labels in the Deposit and Exit components to accurately reflect the validator’s status.
Time Formatting Updates:
Changed time formatting functions from handling seconds to milliseconds by updating formatDurationFromSeconds to formatDurationFromMilliseconds.
Validator Exit Information:
Refactored StakingTxExitDetails to display validator number instead of transaction values when exiting a validator.
Added links to beacon chain explorers in the exit details for users to monitor validator statuses externally.
How to test it
Screenshots
Checklist