Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Multichain] fix: Show notification when adding a new network to an account [SW-173] #4250

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

usame-algan
Copy link
Member

What it solves

Resolves SW-173

How this PR fixes it

  • Shows a notification when replaying a safe on another network
  • Closes the Network selector when closing the add new network form
  • Adds tab navigation to open the network selector collapsed area
  • Removes unused onChange handler and moves the track event call to the form submission

How to test it

  1. Open a Safe
  2. Add new network via the header network selector
  3. Observe the network selector disappears when closing the form
  4. Observe being able to open the collapsed area with keyboard navigation

Screenshots

Screenshot 2024-09-25 at 12 58 50

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

Copy link

github-actions bot commented Sep 25, 2024

Copy link

github-actions bot commented Sep 25, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 990.22 KB (🟡 +35.74 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Fifteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 511 B (🟢 -24.37 KB) 990.72 KB
/address-book 26.09 KB (🟡 +5 B) 1016.31 KB
/apps 50.18 KB (🟡 +174 B) 1.02 MB
/apps/custom 41.81 KB (🟡 +174 B) 1.01 MB
/apps/open 54.74 KB (🟡 +37 B) 1.02 MB
/balances 31 KB (🟡 +73 B) 1021.22 KB
/balances/nfts 19.18 KB (-1 B) 1009.4 KB
/home 60.96 KB (🟡 +1.24 KB) 1.03 MB
/new-safe/advanced-create 36.49 KB (🟡 +1.36 KB) 1 MB
/new-safe/create 35.75 KB (🟡 +1.36 KB) 1 MB
/new-safe/load 16.41 KB (🟡 +10 B) 1006.63 KB
/settings/notifications 27.02 KB (-2 B) 1017.24 KB
/settings/safe-apps 25.56 KB (🟡 +38 B) 1015.78 KB
/settings/setup 35.98 KB (🟡 +5 B) 1 MB
/transactions/tx 21.07 KB (-2 B) 1011.29 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Sep 25, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 78.22% 12418/15875
🔴 Branches 58.16% 3224/5543
🟡 Functions 65.7% 1961/2985
🟡 Lines 79.69% 11204/14060

Test suite run success

1548 tests passing in 206 suites.

Report generated by 🧪jest coverage report action from 7e79651

@usame-algan usame-algan merged commit 3361831 into epic/multichain-safes Sep 26, 2024
12 of 13 checks passed
@usame-algan usame-algan deleted the network-selection branch September 26, 2024 10:37
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants