Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show block explorer link for transaction guards #4257

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

usame-algan
Copy link
Member

What it solves

Resolves #4256

How this PR fixes it

  • Adds the hasExplorer flag to transaction guards

How to test it

  1. Open a safe with a transaction guard
  2. Navigate to the settings page
  3. Observe a block explorer button

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Sep 26, 2024

Copy link
Member

@mmv08 mmv08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

çok iyi

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gut diese

Copy link

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/settings/modules 9.79 KB (🟡 +1 B) 964.41 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 78.12% 11992/15350
🔴 Branches 58.24% 3086/5299
🟡 Functions 65.14% 1889/2900
🟡 Lines 79.63% 10823/13591

Test suite run success

1484 tests passing in 203 suites.

Report generated by 🧪jest coverage report action from 4dc9cf2

@usame-algan usame-algan merged commit da2bdc0 into dev Sep 27, 2024
14 of 15 checks passed
@usame-algan usame-algan deleted the guard-show-explorer-link branch September 27, 2024 09:56
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No block explorer button visible for transaction guards
4 participants