Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: indexing status (SWS-134) #4258

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Feat: indexing status (SWS-134) #4258

merged 3 commits into from
Nov 5, 2024

Conversation

katspaugh
Copy link
Member

What it solves

Resolves https://www.notion.so/safe-global/Show-Indexer-Status-57f83175f045417591f9e8f82e2419bd

Screenshot 2024-09-26 at 16 40 08

How this PR fixes it

The endpoint types have been added here: safe-global/safe-gateway-typescript-sdk#201

The endpoint is currently returning a 500, @iamacook will investigate.

Copy link

github-actions bot commented Sep 26, 2024

Copy link

github-actions bot commented Sep 26, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
73.67% (-0.03% 🔻)
13544/18384
🔴 Branches
51.47% (-0.02% 🔻)
3292/6396
🔴 Functions
57.19% (-0.07% 🔻)
1969/3443
🟡 Lines
75.37% (-0.04% 🔻)
12317/16342
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴
... / index.tsx
46.43% 0% 0% 48.15%

Test suite run success

1573 tests passing in 208 suites.

Report generated by 🧪jest coverage report action from fded789

Copy link

github-actions bot commented Sep 27, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1010.1 KB (🟡 +450 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/apps/open 55.18 KB (-1 B) 1.04 MB
/settings/setup 36 KB (-1 B) 1.02 MB
/transactions 73.69 KB (-1 B) 1.06 MB
/transactions/history 73.65 KB (-1 B) 1.06 MB
/transactions/messages 39.2 KB (-2 B) 1.02 MB
/transactions/msg 29.53 KB (-2 B) 1.02 MB
/transactions/queue 31.3 KB (-1 B) 1.02 MB
/transactions/tx 21.08 KB (-1 B) 1.01 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@katspaugh katspaugh marked this pull request as ready for review September 27, 2024 09:00
@iamacook
Copy link
Member

This should now be unblocked.

@iamacook iamacook removed the blocked label Oct 17, 2024
@francovenica
Copy link
Contributor

LGTM
image
image

@compojoom compojoom merged commit d90cbfa into dev Nov 5, 2024
15 checks passed
@compojoom compojoom deleted the index branch November 5, 2024 17:51
@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants