fix(display-raw-data): Show raw data when the method name and parameters is missing in a tx #4260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch preview✅ Deploy successful! Storybook: |
clovisdasilvaneto
changed the title
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
954.82 KB (🟡 +26 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Coverage reportCaution Test run failed
Show files with reduced coverage 🔻
Test suite run failedFailed tests: 0/1460. Failed suites: 7/203.Report generated by 🧪jest coverage report action from fa1a642 |
katspaugh
approved these changes
Sep 26, 2024
src/components/transactions/TxDetails/TxData/DecodedData/index.tsx
Outdated
Show resolved
Hide resolved
| @@ -50,7 +50,7 @@ export const DecodedData = ({ txData, toInfo }: Props): ReactElement | null => { | |||
| const avatar = addressInfo?.logoUri || toInfo?.logoUri || txData.to.logoUri | |||
|
|
|||
| let decodedData = <></> | |||
| if (txData.dataDecoded) { | |||
| if (txData.dataDecoded && (method || (!method && txData.dataDecoded.parameters))) { | |||
There was a problem hiding this comment.
this check for the parameters and method name is needed because for a native token transfer (from transaction builder) the decoded data comes also with an empty method:
{
"type": "GENERIC",
"method": "",
"parameters": [
{
"name": "to",
"type": "address",
"value": "0xDa5e9FA404881Ff36DDa97b41Da402dF6430EE6b"
},
{
"name": "value",
"type": "uint256",
"value": "1000000000000000000"
}
]
}
schmanu
reviewed
Sep 27, 2024
schmanu
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #4215
How this PR fixes it
it adds the hexData in the txData of the
DecodedTxcomponent and check if there is parameters when the method name is missing, if there are no parameters and method name is missing, we show the raw hexDataHow to test it
Expected: The raw data should appears in the confirmation screen as screenshot bellow
Screenshots
Checklist