Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: icon spacing in EthHashInfo #4269

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Fix: icon spacing in EthHashInfo #4269

merged 1 commit into from
Sep 30, 2024

Conversation

katspaugh
Copy link
Member

What it solves

The spacing inside EthHashInfo was inconsistent.

Before:
Screenshot 2024-09-27 at 15 56 30

After:
Screenshot 2024-09-27 at 15 58 11

Copy link

github-actions bot commented Sep 27, 2024

Copy link

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 954.79 KB (🟡 +3 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
78.1% (-0.01% 🔻)
11999/15364
🔴 Branches
58.21% (-0.02% 🔻)
3084/5298
🟡 Functions 65.09% 1889/2902
🟡 Lines
79.64% (-0.01% 🔻)
10830/13599
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / useTxPendingStatuses.ts
83.64% (-0.91% 🔻)
68.33% (-1.67% 🔻)
75%
92.63% (-1.05% 🔻)

Test suite run success

1484 tests passing in 203 suites.

Report generated by 🧪jest coverage report action from 5a6aa39

Copy link
Contributor

@clovisdasilvaneto clovisdasilvaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@francovenica
Copy link
Contributor

LGMT

@compojoom compojoom merged commit b3f8397 into dev Sep 30, 2024
14 of 15 checks passed
@compojoom compojoom deleted the ethhash branch September 30, 2024 06:23
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants