-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tx-builder-mode): share dark mode information with safe apps #4340
Conversation
Branch preview✅ Deploy successful! Storybook: |
I'll be sending the PR soon to the |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Two Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
Coverage report
Show files with reduced coverage 🔻
Test suite run success1498 tests passing in 203 suites. Report generated by 🧪jest coverage report action from f19cfae |
e74533b
to
17d32ea
Compare
…or send request parameter
What it solves
Resolves safe-global/safe-react-apps#824
How this PR fixes it
It adds the getCurrentTheme method into the app communicator in order to share the darkMode information with the transaction builder or any other safe app.
How to test it
Screenshots
txbuilder.webm
Checklist