Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tx-builder-mode): share dark mode information with safe apps #4340

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

clovisdasilvaneto
Copy link
Contributor

What it solves

Resolves safe-global/safe-react-apps#824

How this PR fixes it

It adds the getCurrentTheme method into the app communicator in order to share the darkMode information with the transaction builder or any other safe app.

How to test it

  • Take the transaction builder dark mode deployed PR link and add it on your safe
  • Open the custom tx-builder app which you just added
  • change the dark mode toggle on the sidebar
  • the transaction builder theme should change according to safe wallet theme

Screenshots

txbuilder.webm

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Oct 8, 2024

@clovisdasilvaneto
Copy link
Contributor Author

I'll be sending the PR soon to the safe-react-apps repository

Copy link

github-actions bot commented Oct 8, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/apps/open 53.19 KB (🟡 +83 B) 1014.36 KB
/home 58.2 KB (🟡 +83 B) 1019.37 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Oct 8, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
78.12% (+3.69% 🔼)
12011/15375
🔴 Branches
58.22% (+5.39% 🔼)
3091/5309
🟡 Functions
65.12% (+6.5% 🔼)
1891/2904
🟡 Lines
79.66% (+3.52% 🔼)
10842/13610
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / pk-popup-store.ts
80% (-10% 🔻)
50% 0% 88.89%
🟢
... / stake.ts
75% (-25% 🔻)
100% 100% 100%
🟢
... / useLoadChains.ts
93.75% (+1.44% 🔼)
66.67% (-33.33% 🔻)
100% 100%

Test suite run success

1498 tests passing in 203 suites.

Report generated by 🧪jest coverage report action from f19cfae

@clovisdasilvaneto clovisdasilvaneto merged commit 51f3a27 into dev Oct 11, 2024
14 of 15 checks passed
@clovisdasilvaneto clovisdasilvaneto deleted the feat/tx-builder-dark-mode branch October 11, 2024 13:57
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add safe wallet dark mode support in the transaction builder
3 participants