Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Backmerge main -> dev #4388

Merged
merged 2 commits into from
Oct 17, 2024
Merged

chore: Backmerge main -> dev #4388

merged 2 commits into from
Oct 17, 2024

Conversation

schmanu
Copy link
Member

@schmanu schmanu commented Oct 17, 2024

Backmerge of main to dev after 1.45.0 release.

schmanu and others added 2 commits October 17, 2024 09:31
@schmanu @usame-algan
1.45.0
73be387
@usame-algan
fix: Show different message in success screen when safe is deployed (#…
d4a352d 
…4385)

* fix: Show different message in success screen when safe is deployed

* fix: store event in success modal
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 17, 2024 •
edited
Loading

Branch preview

✅ Deploy successful!

Website:
https://main--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

Storybook:
https://main--walletweb.review.5afe.dev/storybook/

@github-actions GitHub Actions
Copy link

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 993.3 KB (🟡 +32 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@github-actions GitHub Actions
Copy link

Coverage report

St.❔
 Category Percentage Covered / Total
🟡 Statements
73.67% (-0.02% 🔻)
 13498/18322
🔴 Branches 51.48% 3278/6367
🔴 Functions 57.2% 1966/3437
🟡 Lines
75.38% (-0.02% 🔻)
 12273/16282
Show files with reduced coverage 🔻
St.❔
 File Statements Branches Functions Lines
🔴
... / CounterfactualSuccessScreen.tsx
22.92% (-2.08% 🔻)
 0% 0%
25.58% (-2.62% 🔻)

Test suite run success

1573 tests passing in 208 suites.

Report generated by 🧪jest coverage report action from d4a352d

@compojoom compojoom merged commit d4a352d into dev Oct 17, 2024
35 of 39 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@usame-algan usame-algan usame-algan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmanu @usame-algan @compojoom