[Epic] Safe Proposers #4426
[Epic] Safe Proposers #4426
Conversation
* feat: Add remove delegate button, adjust delegate list layout * feat: Update gateway-sdk package, add delegate form * feat: Optimistically update delegates cache when adding or removing delegate * fix: Add missing ga events, add enum * chore: Update gateway-sdk package * fix: Update setup settings layout * fix: Add notifications when adding and removing proposer * fix: Add validation for add proposer * fix: Rename delegate to proposer * fix: Rename variable for add proposer dialog * fix: Align remove icons in tables * fix: Handle update proposer in rtk query
…#4400) * init * feat: Allow deletion of delegate transactions from the queue * feat: Add text to signer view if tx is from proposer
# Conflicts: # package.json
Branch preview✅ Deploy successful! Storybook: |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
1012.9 KB (🟡 +617 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Eighteen Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/apps |
48.42 KB (-1 B) |
1.04 MB |
/apps/custom |
40.06 KB (-1 B) |
1.03 MB |
/apps/open |
55.36 KB (🟡 +179 B) |
1.04 MB |
/balances |
38.26 KB (-2 B) |
1.03 MB |
/balances/nfts |
19.2 KB (🟡 +1 B) |
1.01 MB |
/settings |
451 B (🟡 +1 B) |
1013.34 KB |
/settings/cookies |
7.68 KB (🟢 -1 B) |
1020.58 KB |
/settings/data |
7.58 KB (🟢 -3 B) |
1020.48 KB |
/settings/environment-variables |
9.17 KB (🟡 +3 B) |
1022.07 KB |
/settings/modules |
9.84 KB (🟢 -3 B) |
1022.74 KB |
/settings/notifications |
27.05 KB (-2 B) |
1.02 MB |
/settings/setup |
47.02 KB (🔴 +11.02 KB) |
1.04 MB |
/transactions |
73.87 KB (🟡 +180 B) |
1.06 MB |
/transactions/history |
73.84 KB (🟡 +180 B) |
1.06 MB |
/transactions/messages |
39.38 KB (🟡 +179 B) |
1.03 MB |
/transactions/msg |
29.71 KB (🟡 +180 B) |
1.02 MB |
/transactions/queue |
31.49 KB (🟡 +177 B) |
1.02 MB |
/transactions/tx |
21.27 KB (🟡 +180 B) |
1.01 MB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success1608 tests passing in 216 suites. Report generated by 🧪jest coverage report action from b5b354d |
* fix: Disable add proposer and delete proposer * fix: Account for owners that are proposers in CheckWallet
# Conflicts: # package.json # src/store/api/gateway/index.ts # yarn.lock
…#4446) * fix: Remove scrollbar when adding proposer * fix: Allow owners being added as proposers * fix: Add check that isProposing only when its also a creation
* feat: Display creator in proposer list * fix: Correctly update proposers when editing and deleting * fix: Remove dangling console.log * fix: Add network switch to delete proposer dialog and reset values when closing
What it solves
Resolves Notion
How this PR fixes it
MembersScreenshots
Checklist