Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use sendTokensBtn instead of sendTokenButn #4452

Conversation

Ang-dot
Copy link

@Ang-dot Ang-dot commented Oct 30, 2024

What it solves

Resolves the namingly-off button variable in cypress test.

How this PR fixes it

Standardizing the naming convention for buttons as in btn. sendTokensButn -> sendTokensBtn

How to test it

Cypress tests

Build a static site:

yarn build

Serve the static files:

yarn serve

Launch the Cypress UI:

yarn cypress:open

Screenshots

Not applicable

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Oct 30, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@Ang-dot
Copy link
Author

Ang-dot commented Oct 30, 2024

I have read the CLA Document and I hereby sign the CLA

@katspaugh
Copy link
Member

Thanks but we try to avoid making cosmetic changes like this. Please feel free to contribute more significant fixes in future.

@katspaugh katspaugh closed this Nov 15, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants