Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(staking-tx): Add staking condition back into the confirmation view #4463

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

clovisdasilvaneto
Copy link
Contributor

What it solves

Adds staking conditional check into the confirmation view since it was in the signOrExecuteForm component before the merge of the confirmation view refactory

How to test it

  • any staking or order tx should work as expected

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Nov 4, 2024

Copy link

github-actions bot commented Nov 4, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 1014.02 KB (-1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Copy link

github-actions bot commented Nov 4, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
74.26% (-0.01% 🔻)
14060/18934
🔴 Branches
52.6% (-0% 🔻)
3476/6608
🔴 Functions 58.04% 2053/3537
🟡 Lines
75.89% (-0.01% 🔻)
12772/16830
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / SignOrExecuteForm.tsx
85.54% (-0.17% 🔻)
76.47% 42.86%
84.81% (-0.19% 🔻)
🟢
... / useTxPendingStatuses.ts
83.64% (-0.91% 🔻)
68.33% (-1.67% 🔻)
75%
92.63% (-1.05% 🔻)

Test suite run success

1619 tests passing in 217 suites.

Report generated by 🧪jest coverage report action from 4e8fbcc

@liliya-soroka
Copy link
Member

Verified

@clovisdasilvaneto clovisdasilvaneto merged commit 18712ff into dev Nov 7, 2024
15 checks passed
@clovisdasilvaneto clovisdasilvaneto deleted the fix/staking-confirmation branch November 7, 2024 09:58
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants