Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Fixes for Safenet Demo #4492

Merged
merged 3 commits into from
Nov 6, 2024
Merged

Small Fixes for Safenet Demo #4492

merged 3 commits into from
Nov 6, 2024

Conversation

nlordell
Copy link
Contributor

@nlordell nlordell commented Nov 6, 2024

Small fixes for the Safenet demo:

  • Wording in transaction details
  • Disable Blockaid for Safenet (as it doesn't seem to work because of the guard)

Copy link

github-actions bot commented Nov 6, 2024

Copy link

github-actions bot commented Nov 6, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1013.58 KB (🟡 +696 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Page Added

The following page was added to the bundle from the code in this PR:

Page Size (compressed) First Load
/settings/safenet 185.31 KB 1.17 MB

Seventeen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/apps 47.15 KB (🟢 -1.27 KB) 1.04 MB
/apps/custom 38.78 KB (🟢 -1.27 KB) 1.03 MB
/apps/open 55.28 KB (🟢 -80 B) 1.04 MB
/balances 30.53 KB (🟢 -7.73 KB) 1.02 MB
/balances/nfts 19.21 KB (🟡 +4 B) 1.01 MB
/home 57.34 KB (🟢 -2.18 KB) 1.05 MB
/new-safe/advanced-create 36.71 KB (🟡 +1.73 KB) 1.03 MB
/new-safe/create 35.97 KB (🟡 +1.73 KB) 1.02 MB
/new-safe/load 16.61 KB (🟡 +1.83 KB) 1.01 MB
/settings/setup 36 KB (🟢 -11.02 KB) 1.02 MB
/stake 597 B (🟡 +1 B) 1014.17 KB
/transactions 73.69 KB (🟢 -187 B) 1.06 MB
/transactions/history 73.66 KB (🟢 -187 B) 1.06 MB
/transactions/messages 39.2 KB (🟢 -186 B) 1.03 MB
/transactions/msg 29.53 KB (🟢 -187 B) 1.02 MB
/transactions/queue 31.3 KB (🟢 -187 B) 1.02 MB
/transactions/tx 21.08 KB (🟢 -188 B) 1.01 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Nov 6, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
73.5% (+0.01% 🔼)
13614/18523
🔴 Branches
51.17% (+0.04% 🔼)
3309/6467
🔴 Functions 56.74% 1974/3479
🟡 Lines
75.18% (+0.01% 🔼)
12382/16470

Test suite run success

1573 tests passing in 208 suites.

Report generated by 🧪jest coverage report action from d3a88af

@nlordell nlordell changed the title change to trigger CI deployment Small Fixes for Safenet Demo Nov 6, 2024
@nlordell nlordell merged commit ed170f0 into safenet Nov 6, 2024
13 checks passed
@nlordell nlordell deleted the safenet-poc/demo branch November 6, 2024 21:05
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants