Release 1.46.0 #4494
Release 1.46.0 #4494
Conversation
* Add twap tests
* chore: create a wrapper on top of signOrExecuteForm to fetch async data before showing the ui * chore: show the confirmation view component based on the transaction type * chore: move presentational layer of reviewOwner to SettingsChange component * chore: do not use showMethodCall to signOrExecuteForm component * feat: Add a loader in the signOrExecuteForm component while the necessary data is not fetched * fix: unit tests * fix: lint errors * mend * fix: pass the txInfo in the useTxDetails mock to avoid null pointer exception * fix: generated snapshots * fix: generated snapshots * fix: change the fundReceiver address on snapshots * fix: remove unnecessary casting * chore: rename useDetailsHook to be useProposeTx * fix: grab the transaction id from the txDetails in case the txId is not provided * fix: rename file from utils to mockData * chore: move the settings component to be exported directly in the index file * fix: add the batch button back to the confirmation views * fix: use the txData component in the confirmation view in case any confirmation view component is found * feat: show an error screen if something happens while fetching the txDetails * fix: show contract name when it is a multisend transaction * fix: eslint errors * fix: move error condition to top of the confirmation view component * fix: do not propose transaction for contrafactual safes * fix: cypress drain e2e test * fix: remove duplicated data in the DecodedTx component * fix: Add back showMethodCall and keep prop drilling it * fix: do not show method call for approve transactions * fix: add showMethodCall into the confirmationView component * fix: pass isApproval down to the confirmation view component * fix: Add isCreation check inside DecodedTx to render partial summary * fix: Update snapshot and mock hex data generation to be even length * chore: generated snapshots * chore: refactor changeThresholdReview screen (#4212) * Approval editor * Fix error display in confirmation screen * chore: unify confirmBatch screen (#4217) * fix(account-flow-import): change import src in the recover account flow screen * fix(eslint): eslint hook dependencies * fix(unit-tests): change txDetails mocked data in unit tests * fix(eslint): change operators order * fix(unit-tests): mock useSafeAddress hook * fix(settings-change): add address name in the change owner screen * fix(settings-change): duplicated owner name in the add owner flow --------- Co-authored-by: Usame Algan <[email protected]> Co-authored-by: katspaugh <[email protected]>
* Fix tests
Add tests for multichain sidebar
* Feat: indexing status (SWS-134) * Add a tooltip * fix: don’t use nested ternaries --------- Co-authored-by: Daniel Dimitrov <[email protected]>
* init * feat: Add remove delegate option and adjust delegate list layout (#4390) * feat: Add remove delegate button, adjust delegate list layout * feat: Update gateway-sdk package, add delegate form * feat: Optimistically update delegates cache when adding or removing delegate * fix: Add missing ga events, add enum * chore: Update gateway-sdk package * fix: Update setup settings layout * fix: Add notifications when adding and removing proposer * fix: Add validation for add proposer * fix: Rename delegate to proposer * fix: Rename variable for add proposer dialog * fix: Align remove icons in tables * fix: Handle update proposer in rtk query * feat: Show Proposal chip for unsigned transactions in the queue (#4422) * feat: Allow deletion of delegate transactions from the queue [SW-297] (#4400) * init * feat: Allow deletion of delegate transactions from the queue * feat: Add text to signer view if tx is from proposer * fix: Disable add proposer and delete proposer [SW-400] [SW-396] (#4429) * fix: Disable add proposer and delete proposer * fix: Account for owners that are proposers in CheckWallet * fix: Adjust message when proposing transaction (#4435) * feat: Edit proposer dialog [SW-391] [SW-396] (#4436) * feat: Show proposer address in queue (#4443) * fix: Hide tooltip on confirm button for proposers (#4444) * fix: Use safe owner address for tenderly simulation with proposer (#4445) * fix: Only show proposal chip if transaction is not pending (#4450) * fix: Allow owners to be added as proposers [SW-407] [SW-428] [SW-381] (#4446) * fix: Remove scrollbar when adding proposer * fix: Allow owners being added as proposers * fix: Add check that isProposing only when its also a creation * fix: Update testid to fix add owner smoke test * fix: Hide batch button for proposers (#4457) * feat: Support hardware wallets for adding and removing proposers (#4466) * feat: Display creator in the proposer list [SW-408] [SW-470] (#4471) * feat: Display creator in proposer list * fix: Correctly update proposers when editing and deleting * fix: Remove dangling console.log * fix: Add network switch to delete proposer dialog and reset values when closing * fix: AdjustVInSignature when managing proposers with a hardware wallet (#4477) * fix: Add proposers feature flag (#4488)
Branch preview✅ Deploy successful! Website: Storybook: |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! One Page Changed SizeThe following page changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success1608 tests passing in 216 suites. Report generated by 🧪jest coverage report action from 2d14d25 |
|
In the Prod CGW the Proposer sections shows up, but the "Add proposer" button does not. Given this all the test regarding proposers were done in the stg cgw
|
|
Blocker issue: There is an issue where the proposers cannot delete himself for not being the owner of the safe: |
|
Minor issue. I don't consider this a blocker |
|
The issues reported were fixed: The add proposer shows now for prod cgw |
#4463) * fix(staking-tx): Add staking condition back into the confirmation view * fix(staking-confirmation): remove typo
Features
Refactors
Tests