Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Blockaid warning styles #4497

Merged
merged 2 commits into from
Nov 11, 2024
Merged

fix: Blockaid warning styles #4497

merged 2 commits into from
Nov 11, 2024

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Nov 6, 2024

What it solves

Resolves #4190

How this PR fixes it

  • Uses static.main for the text color
  • Uses currentColor for the blockaid logo
  • Overwrites the checkbox color to static.main
  • font-weight bold for the warning title
  • Reduces spacing of the list items in the warning

How to test it

  1. Create a transaction on mainnet to transfer funds to an empty EOA or create any other transaction that triggers a warning
  2. Observe the style looks readable in both light and dark mode

Screenshots

Screenshot 2024-11-06 at 20 14 13 Screenshot 2024-11-06 at 20 14 08

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Nov 6, 2024

Copy link

github-actions bot commented Nov 6, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 1012.9 KB (-1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@usame-algan usame-algan changed the title fix: Blockaid warning color fix: Blockaid warning styles Nov 6, 2024
Copy link

github-actions bot commented Nov 6, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 74.28% 13997/18844
🔴 Branches 52.86% 3461/6548
🔴 Functions 58.16% 2049/3523
🟡 Lines 75.91% 12713/16747

Test suite run success

1608 tests passing in 216 suites.

Report generated by 🧪jest coverage report action from 8bcba83

@francovenica
Copy link
Contributor

LGTM:
image

@usame-algan usame-algan merged commit 3e2e66a into dev Nov 11, 2024
15 checks passed
@usame-algan usame-algan deleted the fix-blockaid-warning branch November 11, 2024 10:36
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BlockAid warning style
3 participants