Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Add multichain safe creation flow tests #4520

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Conversation

mike10ca
Copy link
Contributor

@mike10ca mike10ca commented Nov 13, 2024

What it solves

How this PR fixes it

  • Add tests for multichain safe creation flow

How to test it

  • Run Cypress tests and observe outcome

Copy link

github-actions bot commented Nov 13, 2024

Copy link

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1014.13 KB (🟡 +39 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/new-safe/advanced-create 35.03 KB (🟡 +48 B) 1.02 MB
/new-safe/create 34.29 KB (🟡 +48 B) 1.02 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 74.25% 14063/18939
🔴 Branches 52.59% 3477/6612
🔴 Functions 58.04% 2053/3537
🟡 Lines 75.88% 12775/16835

Test suite run success

1619 tests passing in 217 suites.

Report generated by 🧪jest coverage report action from b230531

@francovenica francovenica self-requested a review November 13, 2024 13:54
@mike10ca mike10ca merged commit 66318d1 into dev Nov 13, 2024
15 checks passed
@mike10ca mike10ca deleted the multichain-safeflow branch November 13, 2024 13:55
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants