add eslint back in to setup app

[kswanson33]

I removed some linting in #12, since next linting breaks if files we want to 🔥 aren't there. But eslint is still helpful, especially for removing unused imports.

[philschatz]

👍

[chrisbendel]

i wonder if since next is complaining certain files don't exist, maybe this is why? i wonder what happens if we switch to some other base config we wouldn't have to worry about it

some discussion here

and maybe some relevant docs here

i could be overthinking this though 🤔

[kswanson33]

good catch! I got the error re: next when running next lint (removed here) -- but not when running eslint, even with this setting. But I agree this isn't the best base thing for us to use.

I tried removing the extends field as well as replacing the above line with "extends": "eslint:recommended". Everything seems to work the same, except weirdly, I'm getting the below error in sorter.js

Note that eslint is even disabled above 😱 . Going to keep looking into this ...

[chrisbendel]

woah 😮 that is so weird!!

[nathanstitt]

heads up that nextjs 15 upgrades eslint to the current version and it's config file format changes. management app change to that is here: https://github.com/safeinsights/management-app/pull/48/files#diff-9601a8f6c734c2001be34a2361f76946d19a39a709b5e8c624a2a5a0aade05f2

[kswanson33]

okay, i removed next/core-web-vitals & fixed the above issue by adding config to eslintrc 311d2ec

then the CLI broke in a new weird way (only on Github Actions, worked locally fine). so I updated eslint per nathan's recommendation & migrated eslintrc to eslint.config.mjs using the auto-migrator. now everything works again 🤞...

so that was cool and easy and everything worked as expected

[kswanson33]

i mean -- the current config SHOULD be fine for this project. i just feel like some of these other buggy configs should also have been fine. but whatever 🤷