Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul arch packaging #71

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

james-callahan
Copy link

@james-callahan james-callahan commented Apr 28, 2022

See individual commit messages.

The build works, but there are some TODO items:

  1. I'm having issues with the resulting binary extracting updates:

    $ sudo portmaster-start --data /var/lib/portmaster update
    220428 12:14:29.301 ▶ BOF
    220428 12:14:30.130 r/updating:102 ▶ INFO 001 updates: updated index stable.json with 35 entries
    220428 12:14:30.383 r/updating:102 ▶ INFO 002 updates: updated index all/intel/intel.json with 10 entries
    220428 12:14:30.383 r/updating:133 ▶ INFO 003 updates: everything up to date
    220428 12:14:30.383 r/resource:254 ▶ TRAC 004 updater: selected version 0.8.7 for resource windows_amd64/core/portmaster-core.exe
    220428 12:14:30.383 r/resource:254 ▶ TRAC 005 updater: selected version 0.3.0 for resource all/ui/modules/assets.zip
    220428 12:14:30.383 r/resource:254 ▶ TRAC 006 updater: selected version 1.0.11 for resource windows_amd64/kext/portmaster-kext.sys
    220428 12:14:30.383 r/resource:254 ▶ TRAC 007 updater: selected version 0.7.0 for resource windows_amd64/packages/portmaster-installer.exe
    220428 12:14:30.383 r/resource:254 ▶ TRAC 008 updater: selected version 0.4.6 for resource linux_amd64/hub/spn-hub
    220428 12:14:30.383 r/resource:254 ▶ TRAC 009 updater: selected version 0.1.8 for resource all/ui/modules/settings.zip
    220428 12:14:30.383 r/resource:254 ▶ TRAC 010 updater: selected version 0.8.6 for resource windows_amd64/start/portmaster-start.exe
    220428 12:14:30.383 r/resource:254 ▶ TRAC 011 updater: selected version 0.2.3 for resource all/ui/modules/portmaster.zip
    220428 12:14:30.383 r/resource:254 ▶ TRAC 012 updater: selected version 0.0.5 for resource all/spn/bootstrap.dsd
    220428 12:14:30.383 r/resource:254 ▶ TRAC 013 updater: selected version 20210929.18.58 for resource all/intel/geoip/geoipv4.mmdb.gz
    220428 12:14:30.383 r/resource:254 ▶ TRAC 014 updater: selected version 20210929.18.58 for resource all/intel/geoip/geoipv6.mmdb.gz
    220428 12:14:30.383 r/resource:254 ▶ TRAC 015 updater: selected version 20220111.16.57 for resource all/intel/spn/main-intel.dsd
    220428 12:14:30.383 r/resource:254 ▶ TRAC 016 updater: selected version 2022.2.3 for resource all/intel/lists/index.dsd
    220428 12:14:30.383 r/resource:254 ▶ TRAC 017 updater: selected version 0.8.7 for resource linux_arm64/core/portmaster-core
    220428 12:14:30.383 r/resource:254 ▶ TRAC 018 updater: selected version 0.8.7 for resource windows_arm64/core/portmaster-core.exe
    220428 12:14:30.383 r/resource:254 ▶ TRAC 019 updater: selected version 0.8.6 for resource darwin_amd64/start/portmaster-start
    220428 12:14:30.383 r/resource:254 ▶ TRAC 020 updater: selected version 0.4.6 for resource darwin_amd64/hub/spn-hub
    220428 12:14:30.383 r/resource:254 ▶ TRAC 021 updater: selected version 0.7.0 for resource linux_amd64/packages/portmaster-installer.deb
    220428 12:14:30.383 r/resource:254 ▶ TRAC 022 updater: selected version 0.8.7 for resource darwin_arm64/core/portmaster-core
    220428 12:14:30.383 r/resource:254 ▶ TRAC 023 updater: selected version 0.2.4 for resource linux_amd64/notifier/portmaster-notifier
    220428 12:14:30.383 r/resource:254 ▶ TRAC 024 updater: selected version 0.8.7 for resource darwin_amd64/core/portmaster-core
    220428 12:14:30.383 r/resource:254 ▶ TRAC 025 updater: selected version 0.8.6 for resource windows_arm64/start/portmaster-start.exe
    220428 12:14:30.383 r/resource:254 ▶ TRAC 026 updater: selected version 0.8.7 for resource linux_amd64/core/portmaster-core
    220428 12:14:30.383 r/resource:254 ▶ TRAC 027 updater: selected version 0.3.0 for resource windows_amd64/notifier/portmaster-notifier.exe
    220428 12:14:30.383 r/resource:254 ▶ TRAC 028 updater: selected version 20220331.22.0 for resource all/intel/lists/base.dsdl
    220428 12:14:30.383 r/resource:254 ▶ TRAC 029 updater: selected version 20220113.8.47 for resource all/intel/spn/main-intel.json
    220428 12:14:30.383 r/resource:254 ▶ TRAC 030 updater: selected version 0.8.6 for resource linux_arm64/start/portmaster-start
    220428 12:14:30.383 r/resource:254 ▶ TRAC 031 updater: selected version 1.0.11 for resource windows_amd64/kext/portmaster-kext.dll
    220428 12:14:30.383 r/resource:254 ▶ TRAC 032 updater: selected version 0.8.6 for resource linux_amd64/start/portmaster-start
    220428 12:14:30.383 r/resource:254 ▶ TRAC 033 updater: selected version 0.7.0 for resource linux_amd64/packages/portmaster-installer.rpm
    220428 12:14:30.383 r/resource:254 ▶ TRAC 034 updater: selected version 20211214.14.13 for resource all/intel/portmaster/notifications.json
    220428 12:14:30.383 r/resource:254 ▶ TRAC 035 updater: selected version 20220113.13.47 for resource all/intel/portmaster/notifications.yaml
    220428 12:14:30.383 r/resource:254 ▶ TRAC 036 updater: selected version 20220414.11.51 for resource all/intel/spn/main-intel.yaml
    220428 12:14:30.383 r/resource:254 ▶ TRAC 037 updater: selected version 0.6.0 for resource windows_amd64/notifier/portmaster-snoretoast.exe
    220428 12:14:30.383 r/resource:254 ▶ TRAC 038 updater: selected version 0.1.7 for resource all/ui/modules/profilemgr.zip
    220428 12:14:30.383 r/resource:254 ▶ TRAC 039 updater: selected version 0.4.6 for resource windows_amd64/hub/spn-hub.exe
    220428 12:14:30.383 r/resource:254 ▶ TRAC 040 updater: selected version 0.1.11 for resource all/ui/modules/console.zip
    220428 12:14:30.383 r/resource:254 ▶ TRAC 041 updater: selected version 0.2.4 for resource all/ui/modules/monitor.zip
    220428 12:14:30.383 r/resource:254 ▶ TRAC 042 updater: selected version 0.8.6 for resource darwin_arm64/start/portmaster-start
    220428 12:14:30.383 r/resource:254 ▶ TRAC 043 updater: selected version 20220427.22.0 for resource all/intel/lists/urgent.dsdl
    220428 12:14:30.383 r/resource:254 ▶ TRAC 044 updater: selected version 0.2.3 for resource windows_amd64/app/portmaster-app.zip
    220428 12:14:30.383 r/resource:254 ▶ TRAC 045 updater: selected version 0.2.11 for resource all/ui/modules/base.zip
    220428 12:14:30.383 r/resource:254 ▶ TRAC 046 updater: selected version 0.2.3 for resource linux_amd64/app/portmaster-app.zip
    220428 12:14:30.383 r/resource:254 ▶ TRAC 047 updater: selected version 1.0.11 for resource windows_amd64/kext/portmaster-kext.pdb
    220428 12:14:30.383 r/resource:254 ▶ TRAC 048 updater: selected version 20220423.22.0 for resource all/intel/lists/intermediate.dsdl
    220428 12:14:30.395 ◀ EOF
    Error: failed to unpack resources: 1 error occurred:
        * EOF
    
    
    

    If I unzip manually it all works...

  2. In app I see

    The Portmaster has been launched by an unexpected portmaster-start binary at /usr/bin/portmaster-start. Please configure your system to use the binary at /var/lib/portmaster/portmaster-start as this version will be kept up to date automatically.

    Need to figure out how to dismiss this.

  3. Would like to use system electron.

@james-callahan james-callahan force-pushed the overhaul-arch-packaging branch 2 times, most recently from 67ff29e to 48e91d3 Compare April 28, 2022 02:25
  - Build the go binary instead of downloading prebuilt binary
  - Clean out un-wanted parts of arch.install script
  - Install into normal system directories instead of /opt
  - Reproducible builds (don't embed information about build system into binary)
@james-callahan james-callahan force-pushed the overhaul-arch-packaging branch from 48e91d3 to 7fec81c Compare April 28, 2022 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant