feat: allow to send the headers parameters to pywebpush #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
|
|
||
| def send_notification_to_group(group_name, payload, ttl=0): | ||
| def send_notification_to_group(group_name, payload, ttl=0, headers={}): |
There was a problem hiding this comment.
It is not good idea to take default mutable value. Can you please change it?
| @@ -3,11 +3,11 @@ | |||
| from .utils import send_notification_to_group, send_notification_to_user | |||
|
|
|||
|
|
|||
| def send_group_notification(group_name, payload, ttl=0): | |||
| def send_group_notification(group_name, payload, ttl=0, headers={}): | |||
|
Thanks for the PR. Can you make the changes for mutable default value so we can merge it? |
|
any updates on merging this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pywebpushupdated using>=(Latest versions of pywebpush receive headers parameters).django-webpushfunctions, empty dict by default.