Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper SFR error propagation #108

Merged
merged 4 commits into from
Jan 19, 2024
Merged

Proper SFR error propagation #108

merged 4 commits into from
Jan 19, 2024

Conversation

yymao
Copy link
Member

@yymao yymao commented Jan 18, 2024

@marlageha I made some revision to the code you sent me. Let's discuss!

@yymao yymao requested a review from marlageha January 18, 2024 19:02
Copy link
Contributor

@marlageha marlageha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree adding the SPEC_Z error makes sense. I will test with these errors and look forward to chatting more tomorrow.

@yymao yymao enabled auto-merge January 19, 2024 21:08
@yymao yymao merged commit e8c72bc into master Jan 19, 2024
4 checks passed
@yymao yymao deleted the sfr_error branch January 19, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants