.ci/write-dockerfile.sh: Move here from build/bin/
#37841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 97c3d22; changes) is ready! 🎉 |
kwankyu
reviewed
Apr 22, 2024
Yes, this works well. |
|
Thanks for the review! |
mkoeppe
force-pushed
the
move-write-dockerfile-script
branch
from
6a5201f
to
97c3d22
Compare
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Apr 28, 2024
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> ... as suggested by @kwankyu in https://groups.google.com/g/sage- devel/c/dEa3i2Fn3ZY/m/nzUr2wc_AAAJ To test: Commands such as `tox -e docker-ubuntu-jammy-minimal -- config.status` should still work. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37841 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee, Matthias Köppe
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... as suggested by @kwankyu in https://groups.google.com/g/sage-devel/c/dEa3i2Fn3ZY/m/nzUr2wc_AAAJ
To test: Commands such as
tox -e docker-ubuntu-jammy-minimal -- config.statusshould still work.📝 Checklist
⌛ Dependencies