some tweaks in singular pexpect interface #38356
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 662d151; changes) is ready! 🎉 |
|
This turns out to be more subtle than expected, with several unexpected triggered problems. Some still to be handled. |
|
The failing doctests pass when run alone in the console. How to debug that ? |
fchapoton
force-pushed
the
singular_pexpect
branch
from
456be0a
to
0dd983a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly trying to simplify the conversion of Singular polynomials to sage in the pexpect interface, using appropriate methods in singular.
I have not checked if speed is enhanced or deteriorated.
Also adding a conversion for Singular's "vector" type with a doctest.
📝 Checklist