-
-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ruff PLR1730 checks #38540
fix ruff PLR1730 checks #38540
Conversation
Documentation preview for this PR (built with commit 172ce79; changes) is ready! 🎉 |
@fchapoton I'm not sure how to best rebase this PR on top of your work in #38516 -- any Git/GitHub tips on how to do this best? |
not sure either, sorry. Fetch both branches and merge one into the other ? |
I imagine your CI fix will be merged before this, so I might just wait for this and then I'll rebase from develop |
@fchapoton This now is up to date with your changes which got merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, good
In many places we use comparisons followed by conditional assignment.
PLR1730
identifies this and we can instead usemin
andmax
With #38541 this should fix the three errors from the lint CI (run from develop)
Run from this branch